sandynz commented on code in PR #23026:
URL: https://github.com/apache/shardingsphere/pull/23026#discussion_r1056901933
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/metadata/node/event/handler/PipelineJobConfigurationChangedProcessor.java:
##########
@@ -24,8 +24,7 @@
/**
* Pipeline changed job configuration processor.
*/
-// TODO rename to PipelineJobConfigurationChangedProcessor
-public interface PipelineChangedJobConfigurationProcessor extends TypedSPI {
+public interface PipelineJobConfigurationChangedProcessor extends TypedSPI {
Review Comment:
Keep it for now.
1, It's not decided how to rename it.
2, Refactoring could be in another PR.
##########
proxy/backend/src/main/java/org/apache/shardingsphere/proxy/backend/handler/cdc/CDCBackendHandler.java:
##########
@@ -71,13 +88,53 @@ public CDCResponse createSubscription(final CDCRequest
request) {
}
CreateSubscriptionJobParameter parameter = new
CreateSubscriptionJobParameter(subscriptionRequest.getDatabase(), tableNames,
subscriptionRequest.getSubscriptionName(),
subscriptionRequest.getSubscriptionMode().name(),
actualDataNodesMap);
- CDCJobAPIFactory.getInstance().createJobAndStart(parameter);
- return
CDCResponseGenerator.succeedBuilder(request.getRequestId()).build();
+ if (CDCJobAPIFactory.getInstance().createJob(parameter)) {
+ return
CDCResponseGenerator.succeedBuilder(request.getRequestId()).setCreateSubscriptionResult(CreateSubscriptionResult.newBuilder()
+
.setSubscriptionName(subscriptionRequest.getSubscriptionName()).setExisting(false).build()).build();
+ } else {
+ return
CDCResponseGenerator.succeedBuilder(request.getRequestId()).setCreateSubscriptionResult(CreateSubscriptionResult.newBuilder()
+
.setSubscriptionName(subscriptionRequest.getSubscriptionName()).setExisting(true).build()).build();
+ }
}
private List<DataNode> getActualDataNodes(final ShardingRule shardingRule,
final String logicTableName) {
TableRule tableRule = shardingRule.getTableRule(logicTableName);
// TODO support virtual data source name
return tableRule.getActualDataNodes();
}
+
+ /**
+ * Start subscription.
+ *
+ * @param request request
+ * @param channel channel
+ * @param connectionContext connection context
+ * @return CDC response
+ */
+ public CDCResponse startSubscription(final CDCRequest request, final
Channel channel, final CDCConnectionContext connectionContext) {
+ StartSubscriptionRequest startSubscriptionRequest =
request.getStartSubscription();
+ CDCJobAPI jobAPI = CDCJobAPIFactory.getInstance();
+ String jobId = jobAPI.marshalJobId(new
CDCJobId(startSubscriptionRequest.getDatabase(),
startSubscriptionRequest.getSubscriptionName()));
+ String jobConfigText =
PipelineContext.getContextManager().getMetaDataContexts().getPersistService().getRepository().getDirectly(PipelineMetaDataNode.getJobConfigPath(jobId));
+ if (null == jobConfigText || jobConfigText.isEmpty()) {
+ return CDCResponseGenerator.failed(request.getRequestId(),
CDCResponseErrorCode.SERVER_ERROR, String.format("the %s job config isn't
exists",
+ startSubscriptionRequest.getSubscriptionName()));
+ }
+ JobConfigurationPOJO jobConfigPOJO =
YamlEngine.unmarshal(jobConfigText, JobConfigurationPOJO.class);
Review Comment:
It's better to get job configuration via jobAPI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
