linghengqian opened a new issue, #23218:
URL: https://github.com/apache/shardingsphere/issues/23218

   ## Feature Request
   
   **For English only**, other languages will not accept.
   
   Please pay attention on issues you submitted, because we maybe need more 
details. 
   If no response anymore and we cannot make decision by current information, 
we will **close it**.
   
   Please answer these questions before submitting your issue. Thanks!
   
   ### Is your feature request related to a problem?
   
   - No.
   
   ### Describe the feature you would like.
   
   - For 
https://github.com/apache/shardingsphere/blob/master/mode/type/standalone/repository/provider/jdbc/core/src/main/java/org/apache/shardingsphere/mode/repository/standalone/jdbc/JDBCRepository.java
 , its #getDirectly, #getChildrenKeys, #persist, #persist are all processed 
with consistent Log.
   ```java
   log.error("Get {} data by key: {} failed", getType(), key, ex);
   log.error("Get children {} data by key: {} failed", getType(), key, ex);
   log.error("Persist {} data to key: {} failed", getType(), key, ex);
   log.error("Update {} data to key: {} failed", getType(), key, ex);
   ```
   - except for #delete . I think JDBCRepository#delete should avoid 
String#format .
   ```java
   log.error(String.format("Delete %s data by key: {} failed", getType()), key, 
ex);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to