[GitHub] [shardingsphere] taojintianxia commented on pull request #23393: Refactor : refactor the agent packging structure (#23392)

Sat, 07 Jan 2023 17:15:46 -0800 


taojintianxia commented on PR #23393:
URL: https://github.com/apache/shardingsphere/pull/23393#issuecomment-1374678478

   > How about use `Files.walkFileTree` to simplify the impl
   
   Refactored. 
   
   but I found the guava Files seems more simple
   
   this is the guava implementation:
   <img width="874" alt="image" 
src="https://user-images.githubusercontent.com/4112856/211176291-dd37c2ed-291f-47e2-8d98-d36228e92d64.png";>
   
   this is the nio Files implementation:
   <img width="1075" alt="image" 
src="https://user-images.githubusercontent.com/4112856/211176308-bd9aadb4-6575-4007-b47f-bc0acebcaf97.png";>
   
   the nio Files need to declear an IOException.
   the guava Files has a Beta annotation from guava 19, that's why it has a 
yellow warning in IDEA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to