TeslaCN commented on code in PR #2168:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2168#discussion_r1070831641
##########
elasticjob-lite/elasticjob-lite-core/src/main/java/org/apache/shardingsphere/elasticjob/lite/internal/guarantee/GuaranteeService.java:
##########
@@ -105,21 +109,90 @@ public boolean isRegisterCompleteSuccess(final
Collection<Integer> shardingItems
}
return true;
}
-
+
/**
* Judge whether job's sharding items are all completed.
*
* @return job's sharding items are all completed or not
*/
public boolean isAllCompleted() {
return jobNodeStorage.isJobNodeExisted(GuaranteeNode.COMPLETED_ROOT)
- && configService.load(false).getShardingTotalCount() <=
jobNodeStorage.getJobNodeChildrenKeys(GuaranteeNode.COMPLETED_ROOT).size();
+ && configService.load(false).getShardingTotalCount()
+ <=
jobNodeStorage.getJobNodeChildrenKeys(GuaranteeNode.COMPLETED_ROOT).size();
}
-
+
Review Comment:
Could you revert the unrelated changes in this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
