sandynz opened a new pull request, #23802:
URL: https://github.com/apache/shardingsphere/pull/23802
Changes proposed in this pull request:
- Refactor ShardingSpherePipelineDataSourceCreator to use
YamlShardingSphereDataSourceFactory, replace ShardingSphereDataSourceFactory,
it's more fundemental and flexible, and code could be simplified in
ShardingSpherePipelineDataSourceCreator
- Close created data sources in DataSourcePoolCreator.create when failure
and cache disabled, to avoid possible data source leak
- Clone new YamlRootConfiguration in
ShardingSpherePipelineDataSourceCreator.createPipelineDataSource, to avoid
possible data corruption in original yamlRootConfig
---
Before committing this PR, I'm sure that I have checked the following
options:
- [ ] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
