vikiuvb commented on issue #24010:
URL: 
https://github.com/apache/shardingsphere/issues/24010#issuecomment-1418948700

   @Pace2Car Thanks for the details. 
   
   My 1cents on this change. Rather than removing the functionality, we could 
have extracted the ShardingAlgorithm as a separate resource and introduced 
INLINE/EXTERNAL concept.
   ```
   -> DROP SHARDING TABLE RULE <rule_name>
   if (sharding algorithm used in rule is INLINE): 
         remove the sharding algorithm
   ```
   Repeating the same configurations across the tables violates the DRY 
principle. It is same as asking the developer to define the data source/storage 
unit every time per sharding rule.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to