sandynz commented on code in PR #24263:
URL: https://github.com/apache/shardingsphere/pull/24263#discussion_r1111934075
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/InventoryDumper.java:
##########
@@ -140,12 +140,12 @@ private String buildInventoryDumpSQL() {
if (!dumperConfig.hasUniqueKey()) {
return sqlBuilder.buildNoUniqueKeyInventoryDumpSQL(schemaName,
dumperConfig.getActualTableName());
}
+ PrimaryKeyPosition<?> position = (PrimaryKeyPosition<?>)
dumperConfig.getPosition();
PipelineColumnMetaData firstColumn =
dumperConfig.getUniqueKeyColumns().get(0);
- if (PipelineJdbcUtils.isIntegerColumn(firstColumn.getDataType())) {
+ if (PipelineJdbcUtils.isIntegerColumn(firstColumn.getDataType()) &&
null != position.getBeginValue() && null != position.getEndValue()) {
Review Comment:
`isIntegerColumn` could be the same logic as `isStringColumn`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
