sandynz opened a new pull request, #24295:
URL: https://github.com/apache/shardingsphere/pull/24295
Changes proposed in this pull request:
- Fix migration job target jdbc url changed. JdbcQueryPropertiesExtension
will extend jdbc url parameters when job running, it's not necessary to change
it in job configuration; once it's persisted in job cfg and there's
imcompatible parameter, it's hard to update it.
- Improve migration job source initialization
- Extract createYamlJobConfiguration from createJobAndStart
---
Before committing this PR, I'm sure that I have checked the following
options:
- [ ] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
