azexcy commented on code in PR #24376: URL: https://github.com/apache/shardingsphere/pull/24376#discussion_r1119908855
########## test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/cases/cdc/MySQLCDCE2EIT.java: ########## @@ -0,0 +1,120 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.test.e2e.data.pipeline.cases.cdc; + +import lombok.extern.slf4j.Slf4j; +import org.apache.commons.lang3.tuple.Pair; +import org.apache.shardingsphere.data.pipeline.cdc.api.job.type.CDCJobType; +import org.apache.shardingsphere.data.pipeline.core.util.ThreadUtil; +import org.apache.shardingsphere.infra.database.type.dialect.MySQLDatabaseType; +import org.apache.shardingsphere.test.e2e.data.pipeline.cases.base.PipelineBaseE2EIT; +import org.apache.shardingsphere.test.e2e.data.pipeline.cases.task.CDCIncrementTask; +import org.apache.shardingsphere.test.e2e.data.pipeline.env.enums.PipelineEnvTypeEnum; +import org.apache.shardingsphere.test.e2e.data.pipeline.framework.helper.PipelineCaseHelper; +import org.apache.shardingsphere.test.e2e.data.pipeline.framework.param.PipelineTestParameter; +import org.apache.shardingsphere.test.e2e.data.pipeline.util.DataSourceExecuteUtil; +import org.junit.Test; +import org.junit.runner.RunWith; +import org.junit.runners.Parameterized; +import org.junit.runners.Parameterized.Parameters; +import org.testcontainers.shaded.org.awaitility.Awaitility; + +import java.sql.Connection; +import java.sql.DriverManager; +import java.sql.ResultSet; +import java.sql.SQLException; +import java.time.LocalDateTime; +import java.util.Collection; +import java.util.LinkedList; +import java.util.List; +import java.util.Map; +import java.util.concurrent.TimeUnit; + +import static org.hamcrest.CoreMatchers.is; +import static org.hamcrest.MatcherAssert.assertThat; + +/** + * MySQL CDC E2E IT. + */ +@RunWith(Parameterized.class) +@Slf4j +public final class MySQLCDCE2EIT extends AbstractCDCE2EIT { + + public MySQLCDCE2EIT(final PipelineTestParameter testParam) { + super(testParam); + } + + @Parameters(name = "{0}") + public static Collection<PipelineTestParameter> getTestParameters() { + Collection<PipelineTestParameter> result = new LinkedList<>(); + if (PipelineBaseE2EIT.ENV.getItEnvType() == PipelineEnvTypeEnum.NONE) { + return result; + } + MySQLDatabaseType mysqlDatabaseType = new MySQLDatabaseType(); + for (String each : PipelineBaseE2EIT.ENV.listStorageContainerImages(mysqlDatabaseType)) { + result.add(new PipelineTestParameter(mysqlDatabaseType, each, "env/scenario/general/mysql.xml")); + } + return result; + } + + @Override + protected String getSourceTableOrderName() { + return "t_order"; + } + + @Test + public void assertCDCDataImportSuccess() throws SQLException, InterruptedException { + initEnvironment(getDatabaseType(), new CDCJobType()); + registerStorageUnit(); + createOrderTableRule(); + proxyExecuteWithLog(getExtraSQLCommand().getCreateTableOrder(getSourceTableOrderName()), 0); + Pair<List<Object[]>, List<Object[]>> dataPair = PipelineCaseHelper.generateFullInsertData(getDatabaseType(), 20); + log.info("init data begin: {}", LocalDateTime.now()); + DataSourceExecuteUtil.execute(getProxyDataSource(), getExtraSQLCommand().getFullInsertOrder(getSourceTableOrderName()), dataPair.getLeft()); + log.info("init data end: {}", LocalDateTime.now()); + initImporterTable(); + startCDCClient(); + startIncrementTask(new CDCIncrementTask(getProxyDataSource(), getSourceTableOrderName(), 0, 20, 3)); + getIncreaseTaskThread().join(20000); + List<Map<String, Object>> actualProxyList; + try (Connection connection = getProxyDataSource().getConnection()) { + ResultSet resultSet = connection.createStatement().executeQuery(String.format("SELECT * FROM %s ORDER BY order_id ASC", getOrderTableName())); + actualProxyList = transformResultSetToList(resultSet); + } + // TODO wait CDC sync data finished + ThreadUtil.sleep(4, TimeUnit.SECONDS); + Awaitility.await().atMost(30, TimeUnit.SECONDS).pollInterval(2, TimeUnit.SECONDS).until(() -> listOrderRecords(getSourceTableOrderName()).size() == actualProxyList.size()); Review Comment: Can't reuse now after add query DistSQL, it will be refactor ########## test/e2e/pipeline/src/test/java/org/apache/shardingsphere/test/e2e/data/pipeline/framework/container/compose/DockerContainerComposer.java: ########## @@ -92,6 +92,11 @@ public String getProxyJdbcUrl(final String databaseName) { return DataSourceEnvironment.getURL(databaseType, proxyContainer.getHost(), proxyContainer.getFirstMappedPort(), databaseName); } + @Override Review Comment: now, it's equivalent, but i think `proxyContainer.getMappedPort(3307)` is more clearly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
