RaigorJiang commented on code in PR #24446:
URL: https://github.com/apache/shardingsphere/pull/24446#discussion_r1125681247
##########
proxy/backend/core/src/test/java/org/apache/shardingsphere/proxy/backend/handler/distsql/ral/updatable/ImportDatabaseConfigurationUpdaterTest.java:
##########
@@ -50,101 +48,89 @@
@StaticMockSettings(ProxyContext.class)
public final class ImportDatabaseConfigurationUpdaterTest {
- private final String sharding = "sharding_db";
-
- private final String readwriteSplitting = "readwrite_splitting_db";
-
- private final String databaseDiscovery = "database_discovery_db";
-
- private final String encrypt = "encrypt_db";
-
- private final String shadow = "shadow_db";
-
- private final String mask = "mask_db";
-
- private ImportDatabaseConfigurationUpdater
importDatabaseConfigurationUpdater;
-
- private final Map<String, String> featureMap = new HashMap<>(3, 1);
-
- @BeforeEach
- public void setup() {
- featureMap.put(sharding, "/conf/import/config-sharding.yaml");
- featureMap.put(readwriteSplitting,
"/conf/import/config-readwrite-splitting.yaml");
- featureMap.put(databaseDiscovery,
"/conf/import/config-database-discovery.yaml");
- featureMap.put(encrypt, "/conf/import/config-encrypt.yaml");
- featureMap.put(shadow, "/conf/import/config-shadow.yaml");
- featureMap.put(mask, "/conf/import/config-mask.yaml");
- }
+ private ImportDatabaseConfigurationUpdater importDatabaseConfigUpdater;
@Test
+ @SneakyThrows(SQLException.class)
Review Comment:
In test classes, `throws SQLException` is fine, SneakyThrows is not
recommended
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
