mlycore commented on code in PR #252:
URL:
https://github.com/apache/shardingsphere-on-cloud/pull/252#discussion_r1130583036
##########
charts/apache-shardingsphere-proxy-charts/templates/deployment.yaml:
##########
@@ -49,6 +49,16 @@ spec:
- name: mysql-connect-jar
mountPath: /opt/shardingsphere-proxy/ext-lib
{{- end }}
+ {{- if .Values.compute.agent.enabled }}
+ - name: agent-metrics-jar
+ image: busybox:1.35.0
+ command: ["sh","-c","wget
https://mirrors.aliyun.com/apache/shardingsphere/{{ .Values.compute.image.tag |
default .Chart.AppVersion }}/apache-shardingsphere-{{ .Values.compute.image.tag
| default .Chart.AppVersion }}-shardingsphere-agent-bin.tar.gz;
Review Comment:
Please using Apache official site.
##########
charts/apache-shardingsphere-proxy-charts/templates/configmap.yaml:
##########
@@ -53,3 +53,16 @@ data:
</root>
</configuration>
+
+
+
+{{- if .Values.compute.agent.enabled}}
+---
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: add-metrics
+data:
+ replace-agent.yaml: |-
Review Comment:
Consider change the key from `replace-agent.yaml` to `agent.yaml`
##########
charts/apache-shardingsphere-proxy-charts/templates/deployment.yaml:
##########
@@ -92,3 +113,13 @@ spec:
- name: mysql-connect-jar
emptyDir: { }
{{- end}}
+ {{- if .Values.compute.agent.enabled}}
+ - name: metrics-jar
+ emptyDir: { }
+ - name: agent-config
+ configMap:
+ name: add-metrics
+ items:
+ - key: replace-agent.yaml
Review Comment:
Please update the key from `replace-agent.yaml` to `agent.yaml` if changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
