hyz1994121 commented on PR #24523:
URL: https://github.com/apache/shardingsphere/pull/24523#issuecomment-1469694670

   > > is there anyone can help me review?
   > 
   > Hi, thank you for your pull request, And i think this function are 
provided, you can see `ApolloDriverURLProvider.class`
   
   nonono, in ApolloDriverURLProvider.class,we must set the all yaml file into 
my apollo, 
   in my suggesstion, we can only use some ${} for my config value, which means 
i could not change my apollo config, i just change the config yaml in my 
project, and in my company, we use some placeholder for some account or 
password, in some jar package, program can replace the real password to the 
placeholder. so i provide this parser for the real yaml file in project
   and the placeholder in apollo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to