TeslaCN commented on code in PR #24524:
URL: https://github.com/apache/shardingsphere/pull/24524#discussion_r1136837710
##########
proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/ShardingSphereProxy.java:
##########
@@ -111,4 +146,22 @@ private void initServerBootstrap(final ServerBootstrap
bootstrap) {
.handler(new LoggingHandler(LogLevel.INFO))
.childHandler(new
ServerHandlerInitializer(FrontDatabaseProtocolTypeFactory.getDatabaseType()));
}
+
+ private void initServerBootstrap(final ServerBootstrap bootstrap, final
DomainSocketAddress localDomainSocketAddress) {
+ bootstrap.group(bossGroup, workerGroup)
+ .channel(EpollServerDomainSocketChannel.class)
+ .localAddress(localDomainSocketAddress)
+ .handler(new LoggingHandler(LogLevel.INFO))
+ .childHandler(new
ServerHandlerInitializer(FrontDatabaseProtocolTypeFactory.getDatabaseType()));
+ }
+
+ private void close() {
+ if (null != bossGroup) {
Review Comment:
Is this null check necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
