sandynz commented on code in PR #24440:
URL: https://github.com/apache/shardingsphere/pull/24440#discussion_r1137139927
##########
kernel/data-pipeline/cdc/client/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/client/handler/CDCRequestHandler.java:
##########
@@ -92,21 +90,18 @@ private void sendStartStreamingDataRequest(final
ChannelHandlerContext ctx, fina
private void processDataRecords(final ChannelHandlerContext ctx, final
DataRecordResult result) {
List<Record> recordsList = result.getRecordsList();
- for (Record each : recordsList) {
Review Comment:
`getRecordsList` could be `getRecordList` (`repeated Record record` in
protobuf)
##########
kernel/data-pipeline/cdc/client/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/client/handler/CDCRequestHandler.java:
##########
@@ -49,11 +47,11 @@ public final class CDCRequestHandler extends
ChannelInboundHandlerAdapter {
private final StartCDCClientParameter parameter;
- private final Importer importer;
+ private final RecordConsumer consumer;
Review Comment:
Could `RecordConsumer` be `java.util.function.Consumer<List<Record>>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
