This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 330f41badc4 Add more rules for checkstyle (#24893)
330f41badc4 is described below
commit 330f41badc4a58f0f2247e5d9eb10ae4007b473a
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Mar 29 18:48:21 2023 +0800
Add more rules for checkstyle (#24893)
---
.../yaml/loader/YamlPluginConfigurationLoader.java | 3 --
.../plugin/tracing/TracingAgentExtension.java | 2 +-
.../column/value/string/MySQLJsonValueDecoder.java | 4 +-
.../text/MySQLTextResultSetRowPacketTest.java | 2 +-
.../bind/OpenGaussComBatchBindPacketTest.java | 2 +-
.../extended/bind/PostgreSQLComBindPacketTest.java | 2 +-
.../kernel/fixture/ExecutorCallbackFixture.java | 4 +-
.../constructor/ShardingSphereYamlConstructor.java | 13 +++---
.../driver/spi/ClasspathDriverURLProvider.java | 6 +--
.../data/pipeline/api/job/JobOperationType.java | 2 +-
.../pipeline/cdc/constant/CDCConnectionStatus.java | 4 +-
.../ingest/wal/decode/TestDecodingPlugin.java | 2 +-
src/resources/checkstyle.xml | 53 ++++++++++++++--------
src/resources/checkstyle_ci.xml | 52 +++++++++++++--------
14 files changed, 85 insertions(+), 66 deletions(-)
diff --git
a/agent/core/src/main/java/org/apache/shardingsphere/agent/core/plugin/config/yaml/loader/YamlPluginConfigurationLoader.java
b/agent/core/src/main/java/org/apache/shardingsphere/agent/core/plugin/config/yaml/loader/YamlPluginConfigurationLoader.java
index 1805c3fd7f7..47c454d59b0 100644
---
a/agent/core/src/main/java/org/apache/shardingsphere/agent/core/plugin/config/yaml/loader/YamlPluginConfigurationLoader.java
+++
b/agent/core/src/main/java/org/apache/shardingsphere/agent/core/plugin/config/yaml/loader/YamlPluginConfigurationLoader.java
@@ -20,9 +20,7 @@ package
org.apache.shardingsphere.agent.core.plugin.config.yaml.loader;
import lombok.AccessLevel;
import lombok.NoArgsConstructor;
import
org.apache.shardingsphere.agent.core.plugin.config.yaml.entity.YamlAgentConfiguration;
-import org.apache.shardingsphere.agent.core.yaml.AgentYamlConstructor;
import org.apache.shardingsphere.agent.core.yaml.AgentYamlEngine;
-import org.yaml.snakeyaml.Yaml;
import java.io.File;
import java.io.FileInputStream;
@@ -43,7 +41,6 @@ public final class YamlPluginConfigurationLoader {
* @throws IOException IO exception
*/
public static Optional<YamlAgentConfiguration> load(final File yamlFile)
throws IOException {
- Yaml yaml = new Yaml(new
AgentYamlConstructor(YamlAgentConfiguration.class));
try (FileInputStream fileInputStream = new FileInputStream(yamlFile)) {
YamlAgentConfiguration result =
AgentYamlEngine.unmarshalYamlAgentConfiguration(fileInputStream);
return null == result ? Optional.empty() : Optional.of(result);
diff --git
a/agent/plugins/tracing/test/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/TracingAgentExtension.java
b/agent/plugins/tracing/test/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/TracingAgentExtension.java
index 12ec131e343..ce61832821f 100644
---
a/agent/plugins/tracing/test/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/TracingAgentExtension.java
+++
b/agent/plugins/tracing/test/src/main/java/org/apache/shardingsphere/agent/plugin/tracing/TracingAgentExtension.java
@@ -48,7 +48,7 @@ public final class TracingAgentExtension implements
BeforeAllCallback, AfterAllC
private static final String[] ENHANCEMENT_CLASSES = {
"org.apache.shardingsphere.proxy.frontend.command.CommandExecutorTask",
"org.apache.shardingsphere.infra.executor.sql.execute.engine.driver.jdbc.JDBCExecutorCallback",
-
"org.apache.shardingsphere.infra.parser.ShardingSphereSQLParserEngine",
+
"org.apache.shardingsphere.infra.parser.ShardingSphereSQLParserEngine"
};
@Override
diff --git
a/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoder.java
b/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoder.java
index ecee81b575a..25cdeeb365b 100644
---
a/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoder.java
+++
b/db-protocol/mysql/src/main/java/org/apache/shardingsphere/db/protocol/mysql/packet/binlog/row/column/value/string/MySQLJsonValueDecoder.java
@@ -105,7 +105,7 @@ public final class MySQLJsonValueDecoder {
private static void decodeJsonObject(final boolean isSmall, final ByteBuf
byteBuf, final StringBuilder result) {
result.append('{');
int count = getIntBasedObjectSize(byteBuf, isSmall);
- int size = getIntBasedObjectSize(byteBuf, isSmall);
+ getIntBasedObjectSize(byteBuf, isSmall);
String[] keys = new String[count];
for (int i = 0; i < count; i++) {
keys[i] = decodeKeyEntry(isSmall, byteBuf);
@@ -123,7 +123,7 @@ public final class MySQLJsonValueDecoder {
private static void decodeJsonArray(final boolean isSmall, final ByteBuf
byteBuf, final StringBuilder result) {
result.append('[');
int count = getIntBasedObjectSize(byteBuf, isSmall);
- int size = getIntBasedObjectSize(byteBuf, isSmall);
+ getIntBasedObjectSize(byteBuf, isSmall);
for (int i = 0; i < count; i++) {
if (0 < i) {
result.append(',');
diff --git
a/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
b/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
index 1e874862b4d..58769af5804 100644
---
a/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
+++
b/db-protocol/mysql/src/test/java/org/apache/shardingsphere/db/protocol/mysql/packet/command/query/text/MySQLTextResultSetRowPacketTest.java
@@ -43,7 +43,7 @@ class MySQLTextResultSetRowPacketTest {
@Test
void assertNew() {
when(payload.readStringLenenc()).thenReturn("value_a", null,
"value_c");
- MySQLTextResultSetRowPacket actual = new
MySQLTextResultSetRowPacket(payload, 3);
+ new MySQLTextResultSetRowPacket(payload, 3);
verify(payload, times(3)).readStringLenenc();
}
diff --git
a/db-protocol/opengauss/src/test/java/org/apache/shardingsphere/db/protocol/opengauss/packet/command/query/extended/bind/OpenGaussComBatchBindPacketTest.java
b/db-protocol/opengauss/src/test/java/org/apache/shardingsphere/db/protocol/opengauss/packet/command/query/extended/bind/OpenGaussComBatchBindPacketTest.java
index ee9890f6743..27911743d1a 100644
---
a/db-protocol/opengauss/src/test/java/org/apache/shardingsphere/db/protocol/opengauss/packet/command/query/extended/bind/OpenGaussComBatchBindPacketTest.java
+++
b/db-protocol/opengauss/src/test/java/org/apache/shardingsphere/db/protocol/opengauss/packet/command/query/extended/bind/OpenGaussComBatchBindPacketTest.java
@@ -43,7 +43,7 @@ class OpenGaussComBatchBindPacketTest {
0x00, 0x00, 0x00, 0x02, 0x33, 0x36, 0x00, 0x00,
0x00, 0x01, 0x33, 0x00, 0x00, 0x00, 0x03, 0x54,
0x6f, 0x6d, 0x00, 0x00, 0x00, 0x02, 0x35, 0x34,
- 0x45, 0x00, 0x00, 0x00, 0x00, 0x00,
+ 0x45, 0x00, 0x00, 0x00, 0x00, 0x00
};
@Test
diff --git
a/db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/PostgreSQLComBindPacketTest.java
b/db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/PostgreSQLComBindPacketTest.java
index 4d446b761ea..76dc6055720 100644
---
a/db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/PostgreSQLComBindPacketTest.java
+++
b/db-protocol/postgresql/src/test/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/extended/bind/PostgreSQLComBindPacketTest.java
@@ -35,7 +35,7 @@ class PostgreSQLComBindPacketTest {
0x00, 0x00, 0x00, 0x19, 0x00, 0x53, 0x5f,
0x31, 0x00, 0x00, 0x01, 0x00, 0x01, 0x00, 0x01,
0x00, 0x00, 0x00, 0x04, 0x00, 0x00, 0x00, 0x0a,
- 0x00, 0x00,
+ 0x00, 0x00
};
@Test
diff --git
a/infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/kernel/fixture/ExecutorCallbackFixture.java
b/infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/kernel/fixture/ExecutorCallbackFixture.java
index 4cd01cb9450..eac1493b680 100644
---
a/infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/kernel/fixture/ExecutorCallbackFixture.java
+++
b/infra/executor/src/test/java/org/apache/shardingsphere/infra/executor/kernel/fixture/ExecutorCallbackFixture.java
@@ -33,10 +33,10 @@ public final class ExecutorCallbackFixture implements
ExecutorCallback<Object, S
@Override
public Collection<String> execute(final Collection<Object> inputs, final
boolean isTrunkThread) {
List<String> result = new LinkedList<>();
- for (Object each : inputs) {
+ inputs.forEach(each -> {
latch.countDown();
result.add("succeed");
- }
+ });
return result;
}
}
diff --git
a/infra/util/src/main/java/org/apache/shardingsphere/infra/util/yaml/constructor/ShardingSphereYamlConstructor.java
b/infra/util/src/main/java/org/apache/shardingsphere/infra/util/yaml/constructor/ShardingSphereYamlConstructor.java
index ad58162917b..0389dd68ad5 100644
---
a/infra/util/src/main/java/org/apache/shardingsphere/infra/util/yaml/constructor/ShardingSphereYamlConstructor.java
+++
b/infra/util/src/main/java/org/apache/shardingsphere/infra/util/yaml/constructor/ShardingSphereYamlConstructor.java
@@ -39,12 +39,7 @@ public class ShardingSphereYamlConstructor extends
Constructor {
private final Class<?> rootClass;
public ShardingSphereYamlConstructor(final Class<?> rootClass) {
- super(rootClass, new LoaderOptions() {
-
- {
- setCodePointLimit(Integer.MAX_VALUE);
- }
- });
+ super(rootClass, createLoaderOptions());
ShardingSphereServiceLoader.getServiceInstances(ShardingSphereYamlConstruct.class).forEach(each
-> typeConstructs.put(each.getType(), each));
Map<String, Class<?>> yamlShortcuts = new HashMap<>();
ShardingSphereServiceLoader.getServiceInstances(ShardingSphereYamlShortcuts.class).stream().map(ShardingSphereYamlShortcuts::getYamlShortcuts).forEach(yamlShortcuts::putAll);
@@ -52,6 +47,12 @@ public class ShardingSphereYamlConstructor extends
Constructor {
this.rootClass = rootClass;
}
+ private static LoaderOptions createLoaderOptions() {
+ LoaderOptions result = new LoaderOptions();
+ result.setCodePointLimit(Integer.MAX_VALUE);
+ return result;
+ }
+
@Override
protected final Construct getConstructor(final Node node) {
return typeConstructs.getOrDefault(node.getType(),
super.getConstructor(node));
diff --git
a/jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/spi/ClasspathDriverURLProvider.java
b/jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/spi/ClasspathDriverURLProvider.java
index 839fbfba010..a27998d754a 100644
---
a/jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/spi/ClasspathDriverURLProvider.java
+++
b/jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/spi/ClasspathDriverURLProvider.java
@@ -27,6 +27,7 @@ import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.nio.charset.StandardCharsets;
+import java.util.Arrays;
import java.util.Objects;
/**
@@ -62,10 +63,7 @@ public final class ClasspathDriverURLProvider implements
ShardingSphereDriverURL
}
private InputStream getResourceAsStream(final String resource) {
- ClassLoader[] classLoaders = new ClassLoader[]{
- Thread.currentThread().getContextClassLoader(),
getClass().getClassLoader(), ClassLoader.getSystemClassLoader(),
- };
- for (ClassLoader each : classLoaders) {
+ for (ClassLoader each :
Arrays.asList(Thread.currentThread().getContextClassLoader(),
getClass().getClassLoader(), ClassLoader.getSystemClassLoader())) {
if (null != each) {
InputStream result = each.getResourceAsStream(resource);
if (null == result) {
diff --git
a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/job/JobOperationType.java
b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/job/JobOperationType.java
index 62a8f79bc0c..0ce6397b382 100644
---
a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/job/JobOperationType.java
+++
b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/api/job/JobOperationType.java
@@ -22,5 +22,5 @@ package org.apache.shardingsphere.data.pipeline.api.job;
*/
public enum JobOperationType {
- INSERT, DELETE, UPDATE, SELECT,
+ INSERT, DELETE, UPDATE, SELECT
}
diff --git
a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/constant/CDCConnectionStatus.java
b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/constant/CDCConnectionStatus.java
index 4db5e6a54e6..dfcbc49bc33 100644
---
a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/constant/CDCConnectionStatus.java
+++
b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/constant/CDCConnectionStatus.java
@@ -22,7 +22,5 @@ package org.apache.shardingsphere.data.pipeline.cdc.constant;
*/
public enum CDCConnectionStatus {
- NOT_LOGGED_IN,
-
- LOGGED_IN,
+ NOT_LOGGED_IN, LOGGED_IN
}
diff --git
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java
index bd7ef30e542..a5f0569a7f3 100644
---
a/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java
+++
b/kernel/data-pipeline/dialect/postgresql/src/main/java/org/apache/shardingsphere/data/pipeline/postgresql/ingest/wal/decode/TestDecodingPlugin.java
@@ -117,7 +117,7 @@ public final class TestDecodingPlugin implements
DecodingPlugin {
}
private Object readColumn(final ByteBuffer data) {
- String columnName = readColumnName(data);
+ readColumnName(data);
String columnType = readColumnType(data);
data.get();
return readColumnData(data, columnType);
diff --git a/src/resources/checkstyle.xml b/src/resources/checkstyle.xml
index 214cc92db22..c96132c7550 100644
--- a/src/resources/checkstyle.xml
+++ b/src/resources/checkstyle.xml
@@ -80,11 +80,18 @@
<!-- Whitespace -->
<module name="EmptyForInitializerPad" />
<module name="EmptyForIteratorPad" />
+ <module name="EmptyLineSeparator">
+ <property name="allowMultipleEmptyLines" value="false" />
+ <property name="allowMultipleEmptyLinesInsideClassMembers"
value="false" />
+ </module>
+ <module name="GenericWhitespace" />
<module name="MethodParamPad" />
- <module name="ParenPad" />
- <module name="TypecastParenPad" />
<module name="NoLineWrap" />
+ <module name="NoWhitespaceAfter" />
+ <module name="NoWhitespaceBefore" />
+ <module name="NoWhitespaceBeforeCaseDefaultColon" />
<module name="OperatorWrap" />
+ <module name="ParenPad" />
<module name="SeparatorWrap">
<property name="id" value="SeparatorWrapDot" />
<property name="tokens" value="DOT" />
@@ -110,16 +117,12 @@
<property name="tokens" value="METHOD_REF" />
<property name="option" value="nl" />
</module>
- <module name="GenericWhitespace" />
- <module name="NoWhitespaceBefore" />
- <module name="NoWhitespaceAfter" />
- <module name="WhitespaceAround" />
- <module name="WhitespaceAfter" />
- <module name="SingleSpaceSeparator" />
- <module name="EmptyLineSeparator">
- <property name="allowMultipleEmptyLines" value="false" />
- <property name="allowMultipleEmptyLinesInsideClassMembers"
value="false" />
+ <module name="SingleSpaceSeparator">
+ <property name="validateComments" value="true" />
</module>
+ <module name="TypecastParenPad" />
+ <module name="WhitespaceAfter" />
+ <module name="WhitespaceAround" />
<!-- Imports -->
<module name="AvoidStarImport" />
@@ -141,9 +144,10 @@
<property name="allowSamelineMultipleAnnotations" value="true" />
</module>
<module name="AnnotationUseStyle" />
+ <module name="MissingDeprecated" />
<module name="MissingOverride" />
+ <module name="PackageAnnotation" />
<module name="SuppressWarnings" />
- <module name="MissingDeprecated" />
<module name="SuppressWarningsHolder" />
<!-- Modifiers -->
@@ -151,44 +155,53 @@
<module name="RedundantModifier" />
<!-- Coding -->
- <module name="ArrayTrailingComma" />
+ <module name="AvoidDoubleBraceInitialization" />
+ <module name="AvoidNoArgumentSuperConstructorCall" />
<module name="CovariantEquals" />
- <module name="DefaultComesLast" />
<module name="DeclarationOrder" />
+ <module name="DefaultComesLast" />
<module name="EmptyStatement" />
<module name="EqualsAvoidNull" />
<module name="EqualsHashCode" />
<module name="ExplicitInitialization" />
<module name="FallThrough" />
- <module name="IllegalInstantiation" />
<module name="IllegalCatch" />
+ <module name="IllegalInstantiation" />
<module name="IllegalThrows" />
- <module name="IllegalType">
- <property name="tokens"
value="METHOD_DEF,PARAMETER_DEF,VARIABLE_DEF" />
- </module>
+ <module name="IllegalToken" />
<module name="IllegalTokenText">
<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL" />
<property name="format"
value="\\u00(09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"
/>
<property name="message" value="Consider using special escape
sequence instead of octal value or Unicode escaped value." />
</module>
+ <module name="IllegalType" />
+ <module name="MagicNumber" />
<module name="MissingSwitchDefault" />
<module name="ModifiedControlVariable" />
<module name="MultipleVariableDeclarations" />
<module name="NestedForDepth" />
<module name="NestedIfDepth" />
<module name="NestedTryDepth" />
+ <module name="NoArrayTrailingComma" />
<module name="NoClone" />
+ <module name="NoEnumTrailingComma" />
<module name="NoFinalizer" />
- <module name="SuperClone" />
- <module name="SuperFinalize" />
<module name="OneStatementPerLine" />
<module name="OverloadMethodsDeclarationOrder" />
<module name="PackageDeclaration" />
<module name="ParameterAssignment" />
+ <module name="RequireThis" />
<module name="SimplifyBooleanExpression" />
<module name="SimplifyBooleanReturn" />
<module name="StringLiteralEquality" />
+ <module name="SuperClone" />
+ <module name="SuperFinalize" />
<module name="UnnecessaryParentheses" />
+ <module name="UnnecessarySemicolonAfterOuterTypeDeclaration" />
+ <module name="UnnecessarySemicolonAfterTypeMemberDeclaration" />
+ <module name="UnnecessarySemicolonInEnumeration" />
+ <module name="UnnecessarySemicolonInTryWithResources" />
+ <module name="UnusedLocalVariable" />
<module name="VariableDeclarationUsageDistance" />
<!-- Block Checks -->
diff --git a/src/resources/checkstyle_ci.xml b/src/resources/checkstyle_ci.xml
index 2e7ab7ae2ed..b3a662d5cd7 100644
--- a/src/resources/checkstyle_ci.xml
+++ b/src/resources/checkstyle_ci.xml
@@ -75,11 +75,18 @@
<!-- Whitespace -->
<module name="EmptyForInitializerPad" />
<module name="EmptyForIteratorPad" />
+ <module name="EmptyLineSeparator">
+ <property name="allowMultipleEmptyLines" value="false" />
+ <property name="allowMultipleEmptyLinesInsideClassMembers"
value="false" />
+ </module>
+ <module name="GenericWhitespace" />
<module name="MethodParamPad" />
- <module name="ParenPad" />
- <module name="TypecastParenPad" />
<module name="NoLineWrap" />
+ <module name="NoWhitespaceAfter" />
+ <module name="NoWhitespaceBefore" />
+ <module name="NoWhitespaceBeforeCaseDefaultColon" />
<module name="OperatorWrap" />
+ <module name="ParenPad" />
<module name="SeparatorWrap">
<property name="id" value="SeparatorWrapDot" />
<property name="tokens" value="DOT" />
@@ -105,16 +112,12 @@
<property name="tokens" value="METHOD_REF" />
<property name="option" value="nl" />
</module>
- <module name="GenericWhitespace" />
- <module name="NoWhitespaceBefore" />
- <module name="NoWhitespaceAfter" />
- <module name="WhitespaceAround" />
- <module name="WhitespaceAfter" />
- <module name="SingleSpaceSeparator" />
- <module name="EmptyLineSeparator">
- <property name="allowMultipleEmptyLines" value="false" />
- <property name="allowMultipleEmptyLinesInsideClassMembers"
value="false" />
+ <module name="SingleSpaceSeparator">
+ <property name="validateComments" value="true" />
</module>
+ <module name="TypecastParenPad" />
+ <module name="WhitespaceAfter" />
+ <module name="WhitespaceAround" />
<!-- Imports -->
<module name="AvoidStarImport" />
@@ -136,9 +139,10 @@
<property name="allowSamelineMultipleAnnotations" value="true" />
</module>
<module name="AnnotationUseStyle" />
+ <module name="MissingDeprecated" />
<module name="MissingOverride" />
+ <module name="PackageAnnotation" />
<module name="SuppressWarnings" />
- <module name="MissingDeprecated" />
<module name="SuppressWarningsHolder" />
<!-- Modifiers -->
@@ -146,42 +150,50 @@
<module name="RedundantModifier" />
<!-- Coding -->
- <module name="ArrayTrailingComma" />
+ <module name="AvoidDoubleBraceInitialization" />
+ <module name="AvoidNoArgumentSuperConstructorCall" />
<module name="CovariantEquals" />
- <module name="DefaultComesLast" />
<module name="DeclarationOrder" />
+ <module name="DefaultComesLast" />
<module name="EmptyStatement" />
<module name="EqualsAvoidNull" />
<module name="ExplicitInitialization" />
<module name="FallThrough" />
- <module name="IllegalInstantiation" />
<module name="IllegalCatch" />
+ <module name="IllegalInstantiation" />
<module name="IllegalThrows" />
- <module name="IllegalType">
- <property name="tokens"
value="METHOD_DEF,PARAMETER_DEF,VARIABLE_DEF" />
- </module>
+ <module name="IllegalToken" />
<module name="IllegalTokenText">
<property name="tokens" value="STRING_LITERAL, CHAR_LITERAL" />
<property name="format"
value="\\u00(09|0(a|A)|0(c|C)|0(d|D)|22|27|5(C|c))|\\(0(10|11|12|14|15|42|47)|134)"
/>
<property name="message" value="Consider using special escape
sequence instead of octal value or Unicode escaped value." />
</module>
+ <module name="IllegalType" />
<module name="MissingSwitchDefault" />
<module name="ModifiedControlVariable" />
<module name="MultipleVariableDeclarations" />
<module name="NestedIfDepth" />
<module name="NestedTryDepth" />
+ <module name="NoArrayTrailingComma" />
<module name="NoClone" />
+ <module name="NoEnumTrailingComma" />
<module name="NoFinalizer" />
- <module name="SuperClone" />
- <module name="SuperFinalize" />
<module name="OneStatementPerLine" />
<module name="OverloadMethodsDeclarationOrder" />
<module name="PackageDeclaration" />
<module name="ParameterAssignment" />
+ <module name="RequireThis" />
<module name="SimplifyBooleanExpression" />
<module name="SimplifyBooleanReturn" />
<module name="StringLiteralEquality" />
+ <module name="SuperClone" />
+ <module name="SuperFinalize" />
<module name="UnnecessaryParentheses" />
+ <module name="UnnecessarySemicolonAfterOuterTypeDeclaration" />
+ <module name="UnnecessarySemicolonAfterTypeMemberDeclaration" />
+ <module name="UnnecessarySemicolonInEnumeration" />
+ <module name="UnnecessarySemicolonInTryWithResources" />
+ <module name="UnusedLocalVariable" />
<module name="VariableDeclarationUsageDistance" />
<!-- Block Checks -->
