strongduanmu commented on code in PR #25049:
URL: https://github.com/apache/shardingsphere/pull/25049#discussion_r1166137744
##########
test/it/parser/src/main/resources/case/dml/select-special-function.xml:
##########
@@ -110,7 +110,14 @@
<projections start-index="7" stop-index="35">
<expression-projection text="SUBSTRING('foobarbar' from 4)"
start-index="7" stop-index="35">
<expr>
- <function function-name="SUBSTRING" start-index="7"
stop-index="35" text="SUBSTRING('foobarbar' from 4)" />
+ <function function-name="SUBSTRING" start-index="7"
stop-index="35" text="SUBSTRING('foobarbar' from 4)" >
Review Comment:
You can modify the expected file just like:
```
<function function-name="unix_timestamp" text="unix_timestamp(?)"
literal-text="unix_timestamp('2019-10-19')" start-index="55" stop-index="71"
literal-start-index="55" literal-stop-index="82">
<parameter>
<literal-expression value="2019-10-19"
start-index="70" stop-index="81" />
<parameter-marker-expression parameter-index="0"
start-index="70" stop-index="70" />
</parameter>
</function>
```
##########
test/it/parser/src/main/resources/sql/supported/dml/insert.xml:
##########
@@ -37,7 +37,7 @@
<sql-case id="insert_set_without_generate_key_column" value="INSERT INTO
t_order_item SET order_id = ?, user_id = ?, status = 'insert',
creation_date='2017-08-08'" db-types="MySQL" />
<sql-case id="insert_with_batch" value="INSERT INTO t_order (order_id,
user_id, status) VALUES (?, ?, ?), (?, ?, ?)" db-types="MySQL, SQLServer,
PostgreSQL,openGauss" />
<sql-case id="insert_with_batch_and_irregular_parameters" value="INSERT
INTO t_order (order_id, user_id, status) VALUES (?, 1, 'insert'), (?, ?, ?)"
db-types="MySQL, SQLServer, PostgreSQL,openGauss" />
- <sql-case id="insert_with_batch_and_composite_expression" value="INSERT
INTO t_order (order_id, user_id, status) VALUES (?, ?, SUBSTR(?, 1)), (?, ?,
SUBSTR(?, 1))" db-types="H2,MySQL" />
Review Comment:
Why remove prepared parameters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
