This is an automated email from the ASF dual-hosted git repository.
sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new d3694db8796 Fix MissingOverride rule for pmd (#25224)
d3694db8796 is described below
commit d3694db879683d5401959695cfe05ae62910538a
Author: Liang Zhang <[email protected]>
AuthorDate: Wed Apr 19 11:45:18 2023 +0800
Fix MissingOverride rule for pmd (#25224)
---
.../encrypt/rewrite/condition/impl/EncryptBinaryCondition.java | 7 +------
.../apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java | 1 +
.../core/api/impl/AbstractInventoryIncrementalJobAPIImpl.java | 1 +
.../algorithm/DataMatchDataConsistencyCalculateAlgorithm.java | 1 +
.../core/datasource/DefaultPipelineDataSourceManager.java | 7 +------
.../scenario/migration/config/MigrationJobConfiguration.java | 6 +-----
.../globalclock/core/provider/GlobalClockProvider.java | 9 ---------
.../single/route/engine/SingleStandardRouteEngine.java | 7 +------
.../optimizer/metadata/translatable/TranslatableTableScan.java | 8 +-------
.../checker/dialect/MySQLDataSourcePrivilegeChecker.java | 7 +------
10 files changed, 9 insertions(+), 45 deletions(-)
diff --git
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptBinaryCondition.java
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptBinaryCondition.java
index 8e1365c2ee1..9904520fb24 100644
---
a/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptBinaryCondition.java
+++
b/features/encrypt/core/src/main/java/org/apache/shardingsphere/encrypt/rewrite/condition/impl/EncryptBinaryCondition.java
@@ -79,12 +79,7 @@ public final class EncryptBinaryCondition implements
EncryptCondition {
}
}
- /**
- * Get values.
- *
- * @param params SQL parameters
- * @return values
- */
+ @Override
public List<Object> getValues(final List<Object> params) {
List<Object> result = new ArrayList<>(positionValueMap.values());
for (Entry<Integer, Integer> entry : positionIndexMap.entrySet()) {
diff --git
a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java
b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java
index 01c3134f2b1..62e8fe62a64 100644
---
a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java
+++
b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/job/CDCJob.java
@@ -70,6 +70,7 @@ public final class CDCJob extends AbstractSimplePipelineJob {
return new CDCJobItemContext(jobConfig, shardingItem,
initProgress.orElse(null), jobProcessContext, taskConfig, dataSourceManager,
importerConnector);
}
+ @Override
protected PipelineTasksRunner buildPipelineTasksRunner(final
PipelineJobItemContext pipelineJobItemContext) {
InventoryIncrementalJobItemContext jobItemContext =
(InventoryIncrementalJobItemContext) pipelineJobItemContext;
return new CDCTasksRunner(jobItemContext,
jobItemContext.getInventoryTasks(), jobItemContext.getIncrementalTasks());
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/AbstractInventoryIncrementalJobAPIImpl.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/AbstractInventoryIncrementalJobAPIImpl.java
index 8199e850b03..8ac8fb404a2 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/AbstractInventoryIncrementalJobAPIImpl.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/AbstractInventoryIncrementalJobAPIImpl.java
@@ -101,6 +101,7 @@ public abstract class
AbstractInventoryIncrementalJobAPIImpl extends AbstractPip
return result;
}
+ @Override
protected abstract TableBasedPipelineJobInfo getJobInfo(String jobId);
@Override
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java
index 4b8339c8a23..e85b8211b44 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/check/consistency/algorithm/DataMatchDataConsistencyCalculateAlgorithm.java
@@ -215,6 +215,7 @@ public final class
DataMatchDataConsistencyCalculateAlgorithm extends AbstractSt
private final Collection<Collection<Object>> records;
+ @Override
public Optional<Object> getMaxUniqueKeyValue() {
return Optional.of(maxUniqueKeyValue);
}
diff --git
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/datasource/DefaultPipelineDataSourceManager.java
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/datasource/DefaultPipelineDataSourceManager.java
index ce2a9cbbf33..446a7305a99 100644
---
a/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/datasource/DefaultPipelineDataSourceManager.java
+++
b/kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/datasource/DefaultPipelineDataSourceManager.java
@@ -34,12 +34,7 @@ public final class DefaultPipelineDataSourceManager
implements PipelineDataSourc
private final Map<PipelineDataSourceConfiguration,
PipelineDataSourceWrapper> cachedDataSources = new ConcurrentHashMap<>();
- /**
- * Get cached data source.
- *
- * @param dataSourceConfig data source configuration
- * @return data source
- */
+ @Override
public PipelineDataSourceWrapper getDataSource(final
PipelineDataSourceConfiguration dataSourceConfig) {
PipelineDataSourceWrapper result =
cachedDataSources.get(dataSourceConfig);
if (null != result) {
diff --git
a/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/config/MigrationJobConfiguration.java
b/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/config/MigrationJobConfiguration.java
index 34b0f074b08..dedce350e23 100644
---
a/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/config/MigrationJobConfiguration.java
+++
b/kernel/data-pipeline/scenario/migration/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/migration/config/MigrationJobConfiguration.java
@@ -62,11 +62,7 @@ public final class MigrationJobConfiguration implements
PipelineJobConfiguration
private final int retryTimes;
- /**
- * Get job sharding count.
- *
- * @return job sharding count
- */
+ @Override
public int getJobShardingCount() {
return jobShardingDataNodes.size();
}
diff --git
a/kernel/global-clock/core/src/main/java/org/apache/shardingsphere/globalclock/core/provider/GlobalClockProvider.java
b/kernel/global-clock/core/src/main/java/org/apache/shardingsphere/globalclock/core/provider/GlobalClockProvider.java
index d2a24b92b1f..88ced16dfeb 100644
---
a/kernel/global-clock/core/src/main/java/org/apache/shardingsphere/globalclock/core/provider/GlobalClockProvider.java
+++
b/kernel/global-clock/core/src/main/java/org/apache/shardingsphere/globalclock/core/provider/GlobalClockProvider.java
@@ -20,21 +20,12 @@ package org.apache.shardingsphere.globalclock.core.provider;
import org.apache.shardingsphere.infra.util.spi.annotation.SingletonSPI;
import org.apache.shardingsphere.infra.util.spi.type.typed.TypedSPI;
-import java.util.Properties;
-
/**
* Global clock provider.
*/
@SingletonSPI
public interface GlobalClockProvider extends TypedSPI {
- /**
- * Initialize global clock provider.
- *
- * @param props properties to be initialized
- */
- void init(Properties props);
-
/**
* Get current timestamp.
*
diff --git
a/kernel/single/core/src/main/java/org/apache/shardingsphere/single/route/engine/SingleStandardRouteEngine.java
b/kernel/single/core/src/main/java/org/apache/shardingsphere/single/route/engine/SingleStandardRouteEngine.java
index 2d47668c229..32c85d164c5 100644
---
a/kernel/single/core/src/main/java/org/apache/shardingsphere/single/route/engine/SingleStandardRouteEngine.java
+++
b/kernel/single/core/src/main/java/org/apache/shardingsphere/single/route/engine/SingleStandardRouteEngine.java
@@ -51,12 +51,7 @@ public final class SingleStandardRouteEngine implements
SingleRouteEngine {
private final SQLStatement sqlStatement;
- /**
- * Route for single table.
- *
- * @param routeContext route context
- * @param singleRule single rule
- */
+ @Override
public void route(final RouteContext routeContext, final SingleRule
singleRule) {
if (routeContext.getRouteUnits().isEmpty() || sqlStatement instanceof
SelectStatement) {
route0(routeContext, singleRule);
diff --git
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/translatable/TranslatableTableScan.java
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/translatable/TranslatableTableScan.java
index 03c4123480d..257716b5c9f 100644
---
a/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/translatable/TranslatableTableScan.java
+++
b/kernel/sql-federation/optimizer/src/main/java/org/apache/shardingsphere/sqlfederation/optimizer/metadata/translatable/TranslatableTableScan.java
@@ -150,13 +150,7 @@ public class TranslatableTableScan extends TableScan
implements EnumerableRel {
return super.computeSelfCost(planner, mq).multiplyBy(((double) number
+ 2D) / ((double) table.getRowType().getFieldCount() + 2D));
}
- /**
- * Generate code for translatable table scan.
- *
- * @param implementor EnumerableRelImplementor
- * @param pref Prefer
- * @return generated code
- */
+ @Override
public Result implement(final EnumerableRelImplementor implementor, final
Prefer pref) {
PhysType physType = PhysTypeImpl.of(implementor.getTypeFactory(),
getRowType(), pref.preferArray());
if (null == filters) {
diff --git
a/kernel/transaction/type/xa/core/src/main/java/org/apache/shardingsphere/transaction/xa/jta/datasource/checker/dialect/MySQLDataSourcePrivilegeChecker.java
b/kernel/transaction/type/xa/core/src/main/java/org/apache/shardingsphere/transaction/xa/jta/datasource/checker/dialect/MySQLDataSourcePrivilegeChecker.java
index e380dfc870f..cacc6b61bec 100644
---
a/kernel/transaction/type/xa/core/src/main/java/org/apache/shardingsphere/transaction/xa/jta/datasource/checker/dialect/MySQLDataSourcePrivilegeChecker.java
+++
b/kernel/transaction/type/xa/core/src/main/java/org/apache/shardingsphere/transaction/xa/jta/datasource/checker/dialect/MySQLDataSourcePrivilegeChecker.java
@@ -39,12 +39,7 @@ public final class MySQLDataSourcePrivilegeChecker
implements DataSourcePrivileg
private static final int MYSQL_MAJOR_VERSION_8 = 8;
- /**
- * Check privilege.
- *
- * @param dataSource data source
- * @throws XATransactionCheckPrivilegeFailedException XA transaction check
privilege failed exception
- */
+ @Override
public void checkPrivilege(final DataSource dataSource) {
try (Connection connection = dataSource.getConnection()) {
if (MYSQL_MAJOR_VERSION_8 ==
connection.getMetaData().getDatabaseMajorVersion()) {
