Pace2Car commented on code in PR #25246:
URL: https://github.com/apache/shardingsphere/pull/25246#discussion_r1174529353
##########
features/sharding/core/src/test/java/org/apache/shardingsphere/sharding/algorithm/sharding/classbased/ClassBasedShardingAlgorithmTest.java:
##########
@@ -50,14 +50,22 @@ void assertInitWithNullStrategy() {
@Test
void assertInitWithWrongStrategy() {
- assertThrows(IllegalArgumentException.class, () ->
TypedSPILoader.getService(ShardingAlgorithm.class, "CLASS_BASED",
PropertiesBuilder.build(new Property("strategy", "wrong"))));
+ assertThrows(ShardingAlgorithmInitializationException.class,
+ () -> TypedSPILoader.getService(ShardingAlgorithm.class,
"CLASS_BASED", PropertiesBuilder.build(new Property("strategy", "wrong"))));
}
@Test
void assertInitWithNullClass() {
assertThrows(ShardingAlgorithmInitializationException.class,
() -> TypedSPILoader.getService(ShardingAlgorithm.class,
"CLASS_BASED", PropertiesBuilder.build(new Property("strategy", "standard"))));
}
+
Review Comment:
indentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
