sandynz commented on code in PR #25297:
URL: https://github.com/apache/shardingsphere/pull/25297#discussion_r1174764625
##########
jdbc/core/src/main/java/org/apache/shardingsphere/driver/data/pipeline/datasource/creator/ShardingSpherePipelineDataSourceCreator.java:
##########
@@ -40,7 +40,7 @@ public DataSource createPipelineDataSource(final Object
dataSourceConfig) throws
YamlRootConfiguration rootConfig =
YamlEngine.unmarshal(YamlEngine.marshal(dataSourceConfig),
YamlRootConfiguration.class);
enableStreamingQuery(rootConfig);
ShardingRuleConfigurationConverter.findYamlShardingRuleConfiguration(rootConfig.getRules()).ifPresent(this::enableRangeQueryForInline);
- rootConfig.setDatabaseName(null);
+ rootConfig.setDatabaseName(rootConfig.getDatabaseName());
rootConfig.setSchemaName(null);
Review Comment:
It's better to `setSchemaName` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
