Xu-Wentao commented on code in PR #352:
URL:
https://github.com/apache/shardingsphere-on-cloud/pull/352#discussion_r1189278003
##########
shardingsphere-operator/pkg/reconcile/storagenode/aws/rdsinstance.go:
##########
@@ -116,11 +183,23 @@ func (c *RdsClient) DeleteInstance(ctx context.Context,
node *v1alpha1.StorageNo
if err != nil {
return err
}
- if ins == nil || ins.DBInstanceStatus == "deleting" {
+ if ins == nil || ins.DBInstanceStatus ==
v1alpha1.StorageNodeInstanceStatusDeleting {
return nil
}
- instance.SetDeleteAutomateBackups(true)
- instance.SetSkipFinalSnapshot(true)
+ var isBackup, isSkipFinalSnapshot bool
Review Comment:
use `isDeleteBackup` to replace `isBackup` can more clearly explain what you
want do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
