strongduanmu commented on code in PR #25620:
URL: https://github.com/apache/shardingsphere/pull/25620#discussion_r1194498008
##########
parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/Literals.g4:
##########
@@ -66,10 +66,15 @@ BIT_NUM_
;
IDENTIFIER_
- :
[A-Za-z_$0-9\u0080-\uFFFF]*?[A-Za-z_$\u0080-\uFFFF]+?[A-Za-z_$0-9\u0080-\uFFFF]*
+ : IP_ADDRESS
Review Comment:
> I have defined the IP_ADDRESS lexical rule in the Literals.g4 file and
referenced it in the ipAddress rule in the BaseRule.g4 file. Would this be a
correct approach?
Yes, that's what I mean. Instead of changing the definition of the
identifier, add an ipAddress rule to the textOrIdentifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
