[shardingsphere] branch master updated: Fix sonar issue of CDCBackendHandler (#25748)

[zhangliang]

This is an automated email from the ASF dual-hosted git repository.

zhangliang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 55614ec4784 Fix sonar issue of CDCBackendHandler (#25748)
55614ec4784 is described below

commit 55614ec4784d51466303c348af12fef9fb58097f
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Thu May 18 01:09:03 2023 +0800

    Fix sonar issue of CDCBackendHandler (#25748)
    
    * Fix sonar issue of DatabaseMetaDataResultSet
    
    * Fix sonar issue of CDCBackendHandler
---
 .../pipeline/cdc/handler/CDCBackendHandler.java    | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git 
a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/handler/CDCBackendHandler.java
 
b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/handler/CDCBackendHandler.java
index e5fe2db24bf..10ce752337e 100644
--- 
a/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/handler/CDCBackendHandler.java
+++ 
b/kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/handler/CDCBackendHandler.java
@@ -77,9 +77,9 @@ public final class CDCBackendHandler {
     private final CDCJobAPI jobAPI = new CDCJobAPI();
     
     /**
-     * Get database name by job id.
+     * Get database name by job ID.
      *
-     * @param jobId job id
+     * @param jobId job ID
      * @return database
      */
     public String getDatabaseNameByJobId(final String jobId) {
@@ -89,7 +89,7 @@ public final class CDCBackendHandler {
     /**
      * Stream data.
      *
-     * @param requestId request id
+     * @param requestId request ID
      * @param requestBody stream data request body
      * @param connectionContext connection context
      * @param channel channel
@@ -143,7 +143,7 @@ public final class CDCBackendHandler {
     /**
      * Start streaming.
      *
-     * @param jobId job id
+     * @param jobId job ID
      * @param channel channel
      * @param connectionContext connection context
      */
@@ -164,8 +164,8 @@ public final class CDCBackendHandler {
     /**
      * Stop streaming.
      *
-     * @param jobId job id
-     * @param channelId channel id
+     * @param jobId job ID
+     * @param channelId channel ID
      */
     public void stopStreaming(final String jobId, final ChannelId channelId) {
         if (Strings.isNullOrEmpty(jobId)) {
@@ -173,7 +173,7 @@ public final class CDCBackendHandler {
             return;
         }
         List<Integer> shardingItems = new 
ArrayList<>(PipelineJobCenter.getShardingItems(jobId));
-        if (0 == shardingItems.size()) {
+        if (shardingItems.isEmpty()) {
             return;
         }
         Optional<PipelineJobItemContext> jobItemContext = 
PipelineJobCenter.getJobItemContext(jobId, shardingItems.get(0));
@@ -194,8 +194,8 @@ public final class CDCBackendHandler {
     /**
      * Rollback streaming.
      *
-     * @param jobId job id.
-     * @throws SQLException sql exception
+     * @param jobId job ID
+     * @throws SQLException SQL exception
      */
     public void rollbackStreaming(final String jobId) throws SQLException {
         jobAPI.rollback(jobId);
@@ -204,8 +204,8 @@ public final class CDCBackendHandler {
     /**
      * Commit streaming.
      *
-     * @param jobId job id.
-     * @throws SQLException sql exception
+     * @param jobId job ID
+     * @throws SQLException SQL exception
      */
     public void commitStreaming(final String jobId) throws SQLException {
         jobAPI.commit(jobId);