azexcy commented on code in PR #25787:
URL: https://github.com/apache/shardingsphere/pull/25787#discussion_r1198725177
##########
kernel/data-pipeline/dialect/mysql/src/main/java/org/apache/shardingsphere/data/pipeline/mysql/ingest/client/netty/MySQLBinlogEventPacketDecoder.java:
##########
@@ -104,13 +146,16 @@ private AbstractBinlogEvent decodeEvent(final
MySQLPacketPayload payload, final
case DELETE_ROWS_EVENT_V1:
case DELETE_ROWS_EVENT_V2:
return decodeDeleteRowsEventV2(binlogEventHeader, payload);
+ case QUERY_EVENT:
+ return decodeQueryEvent(binlogEventHeader.getChecksumLength(),
payload);
+ case XID_EVENT:
+ return decodeXidEvent(binlogEventHeader, payload);
default:
- PlaceholderEvent result =
createPlaceholderEvent(binlogEventHeader);
Review Comment:
I hadn't thought of that question, rollback there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
