strongduanmu commented on PR #25814: URL: https://github.com/apache/shardingsphere/pull/25814#issuecomment-1560353531
> @strongduanmu Hi mentor please review. Should we consider making the valueOf method in SQLVisitorRule class ignore case sensitivity when comparing? This could potentially prevent exceptions caused by misspelled rule names. I think more careful code review can avoid this problem. We can't write compatibility code for a mistake, what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
