This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 935d688a998 Remove useless SuppressWarnings (#25890)
935d688a998 is described below
commit 935d688a998980c10b04655a945b0b3560c5bcae
Author: Liang Zhang <[email protected]>
AuthorDate: Thu May 25 18:26:14 2023 +0800
Remove useless SuppressWarnings (#25890)
* Remove generic type of QueryCommandExecutor
* Remove generic type of DatabaseProtocolFrontendEngine
* Remove useless SuppressWarnings
---
.../mysql/handler/admin/executor/MySQLAdminExecutorCreatorTest.java | 1 -
.../mysql/handler/admin/executor/MySQLAdminExecutorFactoryTest.java | 3 ---
.../proxy/frontend/netty/FrontendChannelLimitationInboundHandler.java | 2 +-
.../shardingsphere/proxy/frontend/netty/ServerHandlerInitializer.java | 2 --
.../proxy/frontend/netty/FrontendChannelInboundHandlerTest.java | 1 -
.../proxy/frontend/state/impl/CircuitBreakProxyStateTest.java | 1 -
6 files changed, 1 insertion(+), 9 deletions(-)
diff --git
a/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorCreatorTest.java
b/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorCreatorTest.java
index 163d04b2b56..18f3146ab28 100644
---
a/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorCreatorTest.java
+++
b/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorCreatorTest.java
@@ -75,7 +75,6 @@ import static org.mockito.Mockito.when;
@StaticMockSettings(ProxyContext.class)
class MySQLAdminExecutorCreatorTest {
- @SuppressWarnings("rawtypes")
@Mock
private SQLStatementContext sqlStatementContext;
diff --git
a/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorFactoryTest.java
b/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorFactoryTest.java
index 01979530afd..d9532b73ad7 100644
---
a/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorFactoryTest.java
+++
b/proxy/backend/type/mysql/src/test/java/org/apache/shardingsphere/proxy/backend/mysql/handler/admin/executor/MySQLAdminExecutorFactoryTest.java
@@ -35,7 +35,6 @@ import static org.mockito.Mockito.when;
class MySQLAdminExecutorFactoryTest {
- @SuppressWarnings("rawtypes")
@Test
void assertNewInstanceWithMySQLShowFunctionStatusStatement() {
MySQLShowFunctionStatusStatement statement =
mock(MySQLShowFunctionStatusStatement.class);
@@ -46,7 +45,6 @@ class MySQLAdminExecutorFactoryTest {
assertThat(executor.get(),
instanceOf(ShowFunctionStatusExecutor.class));
}
- @SuppressWarnings("rawtypes")
@Test
void assertNewInstanceWithMySQLShowProcedureStatusStatement() {
MySQLShowProcedureStatusStatement statement =
mock(MySQLShowProcedureStatusStatement.class);
@@ -57,7 +55,6 @@ class MySQLAdminExecutorFactoryTest {
assertThat(executor.get(),
instanceOf(ShowProcedureStatusExecutor.class));
}
- @SuppressWarnings("rawtypes")
@Test
void assertNewInstanceWithMySQLShowTablesStatement() {
MySQLShowTablesStatement statement =
mock(MySQLShowTablesStatement.class);
diff --git
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelLimitationInboundHandler.java
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelLimitationInboundHandler.java
index b9411cde368..2aa055993a0 100644
---
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelLimitationInboundHandler.java
+++
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelLimitationInboundHandler.java
@@ -28,8 +28,8 @@ import
org.apache.shardingsphere.proxy.frontend.spi.DatabaseProtocolFrontendEngi
/**
* Frontend channel limitation inbound handler.
*/
-@Slf4j
@RequiredArgsConstructor
+@Slf4j
public class FrontendChannelLimitationInboundHandler extends
ChannelInboundHandlerAdapter {
private final DatabaseProtocolFrontendEngine
databaseProtocolFrontendEngine;
diff --git
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/ServerHandlerInitializer.java
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/ServerHandlerInitializer.java
index e6a0e222c31..6052ac803ca 100644
---
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/ServerHandlerInitializer.java
+++
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/netty/ServerHandlerInitializer.java
@@ -21,7 +21,6 @@ import io.netty.channel.Channel;
import io.netty.channel.ChannelInitializer;
import io.netty.channel.ChannelPipeline;
import lombok.RequiredArgsConstructor;
-import lombok.extern.slf4j.Slf4j;
import org.apache.shardingsphere.db.protocol.codec.PacketCodec;
import org.apache.shardingsphere.db.protocol.netty.ChannelAttrInitializer;
import org.apache.shardingsphere.db.protocol.netty.ProxyFlowControlHandler;
@@ -33,7 +32,6 @@ import
org.apache.shardingsphere.proxy.frontend.spi.DatabaseProtocolFrontendEngi
* Server handler initializer.
*/
@RequiredArgsConstructor
-@Slf4j
public final class ServerHandlerInitializer extends
ChannelInitializer<Channel> {
private final DatabaseType databaseType;
diff --git
a/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandlerTest.java
b/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandlerTest.java
index 9a594307cf1..42e7b1a82cf 100644
---
a/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandlerTest.java
+++
b/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/netty/FrontendChannelInboundHandlerTest.java
@@ -107,7 +107,6 @@ class FrontendChannelInboundHandlerTest {
assertThat(connectionSession.getDatabaseName(), is("database"));
}
- @SuppressWarnings({"rawtypes", "unchecked"})
@Test
void assertChannelReadNotAuthenticatedAndExceptionOccur() throws Exception
{
channel.register();
diff --git
a/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/state/impl/CircuitBreakProxyStateTest.java
b/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/state/impl/CircuitBreakProxyStateTest.java
index 3723615f9ca..3f6390d1993 100644
---
a/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/state/impl/CircuitBreakProxyStateTest.java
+++
b/proxy/frontend/core/src/test/java/org/apache/shardingsphere/proxy/frontend/state/impl/CircuitBreakProxyStateTest.java
@@ -34,7 +34,6 @@ import static org.mockito.Mockito.when;
class CircuitBreakProxyStateTest {
- @SuppressWarnings({"rawtypes", "unchecked"})
@Test
void assertExecute() {
ChannelHandlerContext channelHandlerContext =
mock(ChannelHandlerContext.class);
