TeslaCN commented on code in PR #25680:
URL: https://github.com/apache/shardingsphere/pull/25680#discussion_r1209653373
##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/dml/SelectStatementContext.java:
##########
@@ -294,8 +296,20 @@ private String getOrderItemText(final
TextOrderByItemSegment orderByItemSegment)
*
* @return group by and order by sequence is same or not
*/
- public boolean isSameGroupByAndOrderByItems() {
- return !groupByContext.getItems().isEmpty() &&
groupByContext.getItems().equals(orderByContext.getItems());
+ public boolean isGroupByStartsWithOrderByItems() {
Review Comment:
@yangsen00 You may refer to
https://github.com/apache/shardingsphere/tree/618548ed8bfc07771bc659ff82b68fe6e9a5d5fd/test/e2e/sql/src/test/resources/cases/dql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
