sandynz commented on code in PR #25950:
URL: https://github.com/apache/shardingsphere/pull/25950#discussion_r1211600591
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/ingest/dumper/InventoryDumper.java:
##########
@@ -146,9 +144,8 @@ private void dump(final PipelineTableMetaData
tableMetaData, final Connection co
rateLimitAlgorithm.intercept(JobOperationType.SELECT,
1);
}
}
- if (!dataRecords.isEmpty()) {
- channel.pushRecords(dataRecords);
- }
+ dataRecords.add(new FinishedRecord(new FinishedPosition()));
+ channel.pushRecords(dataRecords);
Review Comment:
`dataRecords` might be empty, it's the same as before in this case
##########
kernel/data-pipeline/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/ack/CDCAckHolder.java:
##########
@@ -63,7 +63,7 @@ public String bindAckIdWithPosition(final
Map<SocketSinkImporter, CDCAckPosition
private String generateAckId() {
return "ACK-" + UUID.randomUUID();
}
-
+
Review Comment:
The indent should be kept
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
