zihaoAK47 commented on code in PR #26079:
URL: https://github.com/apache/shardingsphere/pull/26079#discussion_r1222404686


##########
test/it/parser/src/main/resources/case/ddl/create-table.xml:
##########
@@ -17,6 +17,12 @@
   -->
 
 <sql-parser-test-cases>
+    <create-table sql-case-id="create_table_with_backtick">
+        <table name="t_order" start-delimiter="`" end-delimiter="`" 
start-index="13" stop-index="23" />

Review Comment:
   @RaigorJiang Tutor, I think the IdentifierValue.getQuotedContent(final 
String text) method is sufficient if we only need to retrieve the content that 
is enclosed by special characters, but this method cannot obtain the actual 
content, such as the real table name of \`t_order\` , which is t_order.
   \`\`\`t_order\`  real table name is  \`t_order
   
   I am confused about whether the IdentifierValue property in the 
TableNameSegment class should represent the real table name. After processing 
with IdentifierValue.getQuotedContent, \`\`\`t_orde\` is transformed into 
\`\`t_order. However, I believe that the IdentifierValue property should 
represent the real table name, which should be \`t_order instead of \`\`t_order.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to