terrymanu commented on a change in pull request #4444: #4255, column definition
information for mysql_stmt_prepare
URL:
https://github.com/apache/incubator-shardingsphere/pull/4444#discussion_r383287228
##########
File path:
sharding-proxy/sharding-proxy-frontend/sharding-proxy-frontend-mysql/src/main/java/org/apache/shardingsphere/shardingproxy/frontend/mysql/command/query/binary/prepare/MySQLComStmtPrepareExecutor.java
##########
@@ -48,26 +49,30 @@ public MySQLComStmtPrepareExecutor(final
MySQLComStmtPreparePacket packet, final
logicSchema = backendConnection.getLogicSchema();
}
+ private int getColumnsCount(final SQLStatement sqlStatement) {
+ return (sqlStatement instanceof SelectStatement) ? ((SelectStatement)
sqlStatement).getProjections().getProjections().size() : 0;
Review comment:
unnecessary brackets of `sqlStatement instanceof SelectStatement`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
