strongduanmu commented on code in PR #26492:
URL: https://github.com/apache/shardingsphere/pull/26492#discussion_r1241440087
##########
parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/mysql/ddl/MySQLDropEventStatement.java:
##########
@@ -17,12 +17,11 @@
package org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.ddl;
-import
org.apache.shardingsphere.sql.parser.sql.common.statement.AbstractSQLStatement;
-import
org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DDLStatement;
+import
org.apache.shardingsphere.sql.parser.sql.common.statement.ddl.DropEventTriggerStatement;
import
org.apache.shardingsphere.sql.parser.sql.dialect.statement.mysql.MySQLStatement;
/**
* MySQL drop event statement.
*/
-public final class MySQLDropEventStatement extends AbstractSQLStatement
implements DDLStatement, MySQLStatement {
+public final class MySQLDropEventStatement extends DropEventTriggerStatement
implements MySQLStatement {
Review Comment:
Why change AbstractSQLStatement to DropEventTriggerStatement? Usually only
when multiple dialects contain this statement will we consider extracting the
common superclass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
