terrymanu commented on a change in pull request #4477: Parse mysql variable
value for SET statement
URL:
https://github.com/apache/incubator-shardingsphere/pull/4477#discussion_r384357941
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java
##########
@@ -32,4 +32,7 @@
@XmlAttribute(name = "variable")
private String variable;
+
+ @XmlAttribute(name = "variableValue")
+ private String variableValue;
Review comment:
Please consider about the name `variable` and `variableValue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services