zihaoAK47 commented on code in PR #26771:
URL: https://github.com/apache/shardingsphere/pull/26771#discussion_r1252755547


##########
parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DMLStatement.g4:
##########
@@ -287,7 +287,10 @@ tableReference
     ;
 
 tableFactor
-    : tableName partitionNames? (AS? alias)? indexHintList? | subquery AS? 
alias (LP_ columnNames RP_)? | LP_ tableReferences RP_

Review Comment:
   Aha, it was only after going through all the rules of table_factor in MySQL 
yacc that I finally understood how to modify it. If want to have a better 
reading experience and easily refer back to MySQL yacc for future 
modifications, I believe refactoring is necessary. What do you think, mentor? 
If we need to refactor, I will start immediately.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to