strongduanmu commented on code in PR #26668:
URL: https://github.com/apache/shardingsphere/pull/26668#discussion_r1257587304
##########
test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/framework/param/model/CaseTestParameter.java:
##########
@@ -44,6 +44,8 @@ public final class CaseTestParameter implements
E2ETestParameter {
@Override
public String toString() {
- return String.format("%s: %s -> %s -> %s", adapter, scenario,
databaseType.getType(), testCaseContext.getTestCase().getSql());
+ final String sql = null == testCaseContext ? null :
testCaseContext.getTestCase().getSql();
Review Comment:
Please remove final modifier here.
##########
test/e2e/env/src/test/java/org/apache/shardingsphere/test/e2e/env/container/atomic/storage/DockerStorageContainer.java:
##########
@@ -76,11 +80,12 @@ protected void configure() {
withClasspathResourceMapping(new
ScenarioDataPath(scenario).getInitSQLResourcePath(Type.EXPECTED, databaseType)
+ "/01-expected-init.sql",
"/docker-entrypoint-initdb.d/01-expected-init.sql",
BindMode.READ_ONLY);
}
+ withClasspathResourceMapping("/container/init-sql/" +
databaseType.getType().toLowerCase() + "/99-be-ready.sql",
"/docker-entrypoint-initdb.d/99-be-ready.sql", BindMode.READ_ONLY);
Review Comment:
Why add 99-be-ready.sql?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
