This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new a2e2c38000a Remove unnecessary throws on 
DataSetEnvironmentManager.fillData() (#26876)
a2e2c38000a is described below

commit a2e2c38000a454608b2b7ee0c113d4ffa2f1a85e
Author: Liang Zhang <[email protected]>
AuthorDate: Mon Jul 10 15:19:47 2023 +0800

    Remove unnecessary throws on DataSetEnvironmentManager.fillData() (#26876)
---
 .../test/e2e/engine/composer/BatchE2EContainerComposer.java            | 2 +-
 .../apache/shardingsphere/test/e2e/engine/type/dml/BaseDMLE2EIT.java   | 3 +--
 .../apache/shardingsphere/test/e2e/engine/type/dql/BaseDQLE2EIT.java   | 2 +-
 3 files changed, 3 insertions(+), 4 deletions(-)

diff --git 
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/composer/BatchE2EContainerComposer.java
 
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/composer/BatchE2EContainerComposer.java
index 148477c92b7..9037fb07d33 100644
--- 
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/composer/BatchE2EContainerComposer.java
+++ 
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/composer/BatchE2EContainerComposer.java
@@ -65,7 +65,7 @@ public final class BatchE2EContainerComposer extends 
E2EContainerComposer implem
     
     private final DateTimeFormatter dateTimeFormatter = 
DateTimeFormatter.ofPattern("yyyy-MM-dd");
     
-    public BatchE2EContainerComposer(final CaseTestParameter testParam) throws 
JAXBException, IOException, SQLException {
+    public BatchE2EContainerComposer(final CaseTestParameter testParam) throws 
JAXBException, IOException {
         super(testParam);
         databaseType = testParam.getDatabaseType();
         for (IntegrationTestCaseAssertion each : 
testParam.getTestCaseContext().getTestCase().getAssertions()) {
diff --git 
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dml/BaseDMLE2EIT.java
 
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dml/BaseDMLE2EIT.java
index 459ef327969..6473263866c 100644
--- 
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dml/BaseDMLE2EIT.java
+++ 
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dml/BaseDMLE2EIT.java
@@ -73,8 +73,7 @@ public abstract class BaseDMLE2EIT {
      * @throws JAXBException JAXB exception
      */
     public final void init(final AssertionTestParameter testParam, final 
SingleE2EContainerComposer containerComposer) throws SQLException, IOException, 
JAXBException {
-        dataSetEnvironmentManager = new DataSetEnvironmentManager(
-                new 
ScenarioDataPath(testParam.getScenario()).getDataSetFile(Type.ACTUAL), 
containerComposer.getActualDataSourceMap());
+        dataSetEnvironmentManager = new DataSetEnvironmentManager(new 
ScenarioDataPath(testParam.getScenario()).getDataSetFile(Type.ACTUAL), 
containerComposer.getActualDataSourceMap());
         dataSetEnvironmentManager.fillData();
     }
     
diff --git 
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dql/BaseDQLE2EIT.java
 
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dql/BaseDQLE2EIT.java
index 7f5a2c525fb..5bb97679791 100644
--- 
a/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dql/BaseDQLE2EIT.java
+++ 
b/test/e2e/sql/src/test/java/org/apache/shardingsphere/test/e2e/engine/type/dql/BaseDQLE2EIT.java
@@ -72,7 +72,7 @@ public abstract class BaseDQLE2EIT {
         useXMLAsExpectedDataset = null != 
containerComposer.getAssertion().getExpectedDataFile();
     }
     
-    private void fillDataOnlyOnce(final AssertionTestParameter testParam, 
final SingleE2EContainerComposer containerComposer) throws SQLException, 
IOException, JAXBException {
+    private void fillDataOnlyOnce(final AssertionTestParameter testParam, 
final SingleE2EContainerComposer containerComposer) throws IOException, 
JAXBException {
         String cacheKey = testParam.getKey() + "-" + 
System.identityHashCode(containerComposer.getActualDataSourceMap());
         if (!FILLED_SUITES.contains(cacheKey)) {
             synchronized (FILLED_SUITES) {

Reply via email to