strongduanmu opened a new issue, #26885:
URL: https://github.com/apache/shardingsphere/issues/26885

   ## Feature Request
   
   ### Is your feature request related to a problem?
   
   No.
   
   ### Describe the feature you would like.
   
   Currently, when ShardingSphere creates a ShardingSphereDataSource, it 
creates a JDBCContext, which maintains a CachedDatabaseMetaData object to be 
compatible with most JDBC interfaces.
   
   ```java
   /**
    * ShardingSphere data source.
    */
   public final class ShardingSphereDataSource extends 
AbstractDataSourceAdapter implements AutoCloseable {
       
       private final String databaseName;
       
       private final ContextManager contextManager;
       
       private final JDBCContext jdbcContext;
       
       public ShardingSphereDataSource(final String databaseName, final 
ModeConfiguration modeConfig) throws SQLException {
           this.databaseName = databaseName;
           contextManager = createContextManager(databaseName, modeConfig, new 
LinkedHashMap<>(), new LinkedList<>(), new Properties());
           jdbcContext = new 
JDBCContext(contextManager.getDataSourceMap(databaseName));
           contextManagerInitializedCallback(databaseName, contextManager);
       }
       
       public ShardingSphereDataSource(final String databaseName, final 
ModeConfiguration modeConfig, final Map<String, DataSource> dataSourceMap,
                                       final Collection<RuleConfiguration> 
ruleConfigs, final Properties props) throws SQLException {
           this.databaseName = databaseName;
           contextManager = createContextManager(databaseName, modeConfig, 
dataSourceMap, ruleConfigs, null == props ? new Properties() : props);
           jdbcContext = new 
JDBCContext(contextManager.getDataSourceMap(databaseName));
           contextManagerInitializedCallback(databaseName, contextManager);
       }
   ```
   
   The CachedDatabaseMetaData object caches the properties in the 
DatabaseMetaData of the native data, but when some interfaces are not 
implemented, SQLFeatureNotSupportedException will be thrown, causing the 
application to fail to start.
   
   ```java
       public CachedDatabaseMetaData(final DatabaseMetaData databaseMetaData) 
throws SQLException {
           url = databaseMetaData.getURL();
           userName = databaseMetaData.getUserName();
           databaseProductName = databaseMetaData.getDatabaseProductName();
           databaseProductVersion = 
databaseMetaData.getDatabaseProductVersion();
           driverName = databaseMetaData.getDriverName();
           driverVersion = databaseMetaData.getDriverVersion();
           driverMajorVersion = databaseMetaData.getDriverMajorVersion();
           driverMinorVersion = databaseMetaData.getDriverMinorVersion();
           databaseMajorVersion = databaseMetaData.getDatabaseMajorVersion();
           databaseMinorVersion = databaseMetaData.getDatabaseMinorVersion();
           jdbcMajorVersion = databaseMetaData.getJDBCMajorVersion();
           jdbcMinorVersion = databaseMetaData.getJDBCMinorVersion();
           isReadOnly = databaseMetaData.isReadOnly();
           allProceduresAreCallable = 
databaseMetaData.allProceduresAreCallable();
           allTablesAreSelectable = databaseMetaData.allTablesAreSelectable();
           nullsAreSortedHigh = databaseMetaData.nullsAreSortedHigh();
           nullsAreSortedLow = databaseMetaData.nullsAreSortedLow();
           nullsAreSortedAtStart = databaseMetaData.nullsAreSortedAtStart();
           nullsAreSortedAtEnd = databaseMetaData.nullsAreSortedAtEnd();
           usesLocalFiles = databaseMetaData.usesLocalFiles();
           usesLocalFilePerTable = databaseMetaData.usesLocalFilePerTable();
           supportsMixedCaseIdentifiers = 
databaseMetaData.supportsMixedCaseIdentifiers();
           storesUpperCaseIdentifiers = 
databaseMetaData.storesUpperCaseIdentifiers();
           storesLowerCaseIdentifiers = 
databaseMetaData.storesLowerCaseIdentifiers();
           storesMixedCaseIdentifiers = 
databaseMetaData.storesMixedCaseIdentifiers();
           supportsMixedCaseQuotedIdentifiers = 
databaseMetaData.supportsMixedCaseQuotedIdentifiers();
           storesUpperCaseQuotedIdentifiers = 
databaseMetaData.storesUpperCaseQuotedIdentifiers();
           storesLowerCaseQuotedIdentifiers = 
databaseMetaData.storesLowerCaseQuotedIdentifiers();
           storesMixedCaseQuotedIdentifiers = 
databaseMetaData.storesMixedCaseQuotedIdentifiers();
           identifierQuoteString = databaseMetaData.getIdentifierQuoteString();
           sqlKeywords = databaseMetaData.getSQLKeywords();
           numericFunctions = databaseMetaData.getNumericFunctions();
           stringFunctions = databaseMetaData.getStringFunctions();
           systemFunctions = databaseMetaData.getSystemFunctions();
           timeDateFunctions = databaseMetaData.getTimeDateFunctions();
           searchStringEscape = databaseMetaData.getSearchStringEscape();
           extraNameCharacters = databaseMetaData.getExtraNameCharacters();
           supportsAlterTableWithAddColumn = 
databaseMetaData.supportsAlterTableWithAddColumn();
           supportsAlterTableWithDropColumn = 
databaseMetaData.supportsAlterTableWithDropColumn();
           supportsColumnAliasing = databaseMetaData.supportsColumnAliasing();
           nullPlusNonNullIsNull = databaseMetaData.nullPlusNonNullIsNull();
           supportsConvert = databaseMetaData.supportsConvert();
           supportsTableCorrelationNames = 
databaseMetaData.supportsTableCorrelationNames();
           supportsDifferentTableCorrelationNames = 
databaseMetaData.supportsDifferentTableCorrelationNames();
           supportsExpressionsInOrderBy = 
databaseMetaData.supportsExpressionsInOrderBy();
           supportsOrderByUnrelated = 
databaseMetaData.supportsOrderByUnrelated();
           supportsGroupBy = databaseMetaData.supportsGroupBy();
           supportsGroupByUnrelated = 
databaseMetaData.supportsGroupByUnrelated();
           supportsGroupByBeyondSelect = 
databaseMetaData.supportsGroupByBeyondSelect();
           supportsLikeEscapeClause = 
databaseMetaData.supportsLikeEscapeClause();
           supportsMultipleResultSets = 
databaseMetaData.supportsMultipleResultSets();
           supportsMultipleTransactions = 
databaseMetaData.supportsMultipleTransactions();
           supportsNonNullableColumns = 
databaseMetaData.supportsNonNullableColumns();
           supportsMinimumSQLGrammar = 
databaseMetaData.supportsMinimumSQLGrammar();
           supportsCoreSQLGrammar = databaseMetaData.supportsCoreSQLGrammar();
           supportsExtendedSQLGrammar = 
databaseMetaData.supportsExtendedSQLGrammar();
           supportsANSI92EntryLevelSQL = 
databaseMetaData.supportsANSI92EntryLevelSQL();
           supportsANSI92IntermediateSQL = 
databaseMetaData.supportsANSI92IntermediateSQL();
           supportsANSI92FullSQL = databaseMetaData.supportsANSI92FullSQL();
           supportsIntegrityEnhancementFacility = 
databaseMetaData.supportsIntegrityEnhancementFacility();
           supportsOuterJoins = databaseMetaData.supportsOuterJoins();
           supportsFullOuterJoins = databaseMetaData.supportsFullOuterJoins();
           supportsLimitedOuterJoins = 
databaseMetaData.supportsLimitedOuterJoins();
           schemaTerm = databaseMetaData.getSchemaTerm();
           procedureTerm = databaseMetaData.getProcedureTerm();
           catalogTerm = databaseMetaData.getCatalogTerm();
           isCatalogAtStart = databaseMetaData.isCatalogAtStart();
           catalogSeparator = databaseMetaData.getCatalogSeparator();
           supportsSchemasInDataManipulation = 
databaseMetaData.supportsSchemasInDataManipulation();
           supportsSchemasInProcedureCalls = 
databaseMetaData.supportsSchemasInProcedureCalls();
           supportsSchemasInTableDefinitions = 
databaseMetaData.supportsSchemasInTableDefinitions();
           supportsSchemasInIndexDefinitions = 
databaseMetaData.supportsSchemasInIndexDefinitions();
           supportsSchemasInPrivilegeDefinitions = 
databaseMetaData.supportsSchemasInPrivilegeDefinitions();
           supportsCatalogsInDataManipulation = 
databaseMetaData.supportsCatalogsInDataManipulation();
           supportsCatalogsInProcedureCalls = 
databaseMetaData.supportsCatalogsInProcedureCalls();
           supportsCatalogsInTableDefinitions = 
databaseMetaData.supportsCatalogsInTableDefinitions();
           supportsCatalogsInIndexDefinitions = 
databaseMetaData.supportsCatalogsInIndexDefinitions();
           supportsCatalogsInPrivilegeDefinitions = 
databaseMetaData.supportsCatalogsInPrivilegeDefinitions();
           supportsPositionedDelete = 
databaseMetaData.supportsPositionedDelete();
           supportsPositionedUpdate = 
databaseMetaData.supportsPositionedUpdate();
           supportsSelectForUpdate = databaseMetaData.supportsSelectForUpdate();
           supportsStoredProcedures = 
databaseMetaData.supportsStoredProcedures();
           supportsSubqueriesInComparisons = 
databaseMetaData.supportsSubqueriesInComparisons();
           supportsSubqueriesInExists = 
databaseMetaData.supportsSubqueriesInExists();
           supportsSubqueriesInIns = databaseMetaData.supportsSubqueriesInIns();
           supportsSubqueriesInQuantifieds = 
databaseMetaData.supportsSubqueriesInQuantifieds();
           supportsCorrelatedSubqueries = 
databaseMetaData.supportsCorrelatedSubqueries();
           supportsUnion = databaseMetaData.supportsUnion();
           supportsUnionAll = databaseMetaData.supportsUnionAll();
           supportsOpenCursorsAcrossCommit = 
databaseMetaData.supportsOpenCursorsAcrossCommit();
           supportsOpenCursorsAcrossRollback = 
databaseMetaData.supportsOpenCursorsAcrossRollback();
           supportsOpenStatementsAcrossCommit = 
databaseMetaData.supportsOpenStatementsAcrossCommit();
           supportsOpenStatementsAcrossRollback = 
databaseMetaData.supportsOpenStatementsAcrossRollback();
           maxBinaryLiteralLength = 
databaseMetaData.getMaxBinaryLiteralLength();
           maxCharLiteralLength = databaseMetaData.getMaxCharLiteralLength();
           maxColumnNameLength = databaseMetaData.getMaxColumnNameLength();
           maxColumnsInGroupBy = databaseMetaData.getMaxColumnsInGroupBy();
           maxColumnsInIndex = databaseMetaData.getMaxColumnsInIndex();
           maxColumnsInOrderBy = databaseMetaData.getMaxColumnsInOrderBy();
           maxColumnsInSelect = databaseMetaData.getMaxColumnsInSelect();
           maxColumnsInTable = databaseMetaData.getMaxColumnsInTable();
           maxConnections = databaseMetaData.getMaxConnections();
           maxCursorNameLength = databaseMetaData.getMaxCursorNameLength();
           maxIndexLength = databaseMetaData.getMaxIndexLength();
           maxSchemaNameLength = databaseMetaData.getMaxSchemaNameLength();
           maxProcedureNameLength = 
databaseMetaData.getMaxProcedureNameLength();
           maxCatalogNameLength = databaseMetaData.getMaxCatalogNameLength();
           maxRowSize = databaseMetaData.getMaxRowSize();
           doesMaxRowSizeIncludeBlobs = 
databaseMetaData.doesMaxRowSizeIncludeBlobs();
           maxStatementLength = databaseMetaData.getMaxStatementLength();
           maxStatements = databaseMetaData.getMaxStatements();
           maxTableNameLength = databaseMetaData.getMaxTableNameLength();
           maxTablesInSelect = databaseMetaData.getMaxTablesInSelect();
           maxUserNameLength = databaseMetaData.getMaxUserNameLength();
           defaultTransactionIsolation = 
databaseMetaData.getDefaultTransactionIsolation();
           supportsTransactions = databaseMetaData.supportsTransactions();
           supportsDataDefinitionAndDataManipulationTransactions = 
databaseMetaData.supportsDataDefinitionAndDataManipulationTransactions();
           supportsDataManipulationTransactionsOnly = 
databaseMetaData.supportsDataManipulationTransactionsOnly();
           dataDefinitionCausesTransactionCommit = 
databaseMetaData.dataDefinitionCausesTransactionCommit();
           dataDefinitionIgnoredInTransactions = 
databaseMetaData.dataDefinitionIgnoredInTransactions();
           supportsBatchUpdates = databaseMetaData.supportsBatchUpdates();
           supportsSavepoints = databaseMetaData.supportsSavepoints();
           supportsNamedParameters = databaseMetaData.supportsNamedParameters();
           supportsMultipleOpenResults = 
databaseMetaData.supportsMultipleOpenResults();
           supportsGetGeneratedKeys = 
databaseMetaData.supportsGetGeneratedKeys();
           resultSetHoldability = databaseMetaData.getResultSetHoldability();
           sqlStateType = databaseMetaData.getSQLStateType();
           locatorsUpdateCopy = databaseMetaData.locatorsUpdateCopy();
           supportsStatementPooling = 
databaseMetaData.supportsStatementPooling();
           supportsStoredFunctionsUsingCallSyntax = 
databaseMetaData.supportsStoredFunctionsUsingCallSyntax();
           autoCommitFailureClosesAllResultSets = 
databaseMetaData.autoCommitFailureClosesAllResultSets();
           rowIdLifetime = getRowIdLifetimeFromOriginMetaData(databaseMetaData);
           generatedKeyAlwaysReturned = 
isGeneratedKeyAlwaysReturned(databaseMetaData);
       }
   ```
   
   A feasible way is to try cache to catch the exception and then return the 
default value, but this is consistent with the behavior of the native JDBC 
driver, and ShardingSphere should throw the same exception as the native JDBC 
driver.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: 
[email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to