This is an automated email from the ASF dual-hosted git repository.
sunnianjun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 3de17dc4838 Fix test case for PipelineSQLSegmentBuilderTest (#27187)
3de17dc4838 is described below
commit 3de17dc48382e6f826c25ddce0efd6b33632fa20
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jul 14 00:54:20 2023 +0800
Fix test case for PipelineSQLSegmentBuilderTest (#27187)
---
.../infra/fixture/InfraBranchDatabaseTypeFixture.java | 5 -----
.../common/sqlbuilder/PipelineSQLSegmentBuilderTest.java | 10 +++++-----
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git
a/infra/common/src/test/java/org/apache/shardingsphere/infra/fixture/InfraBranchDatabaseTypeFixture.java
b/infra/common/src/test/java/org/apache/shardingsphere/infra/fixture/InfraBranchDatabaseTypeFixture.java
index 6a4bbd8423b..19106eaa202 100644
---
a/infra/common/src/test/java/org/apache/shardingsphere/infra/fixture/InfraBranchDatabaseTypeFixture.java
+++
b/infra/common/src/test/java/org/apache/shardingsphere/infra/fixture/InfraBranchDatabaseTypeFixture.java
@@ -60,11 +60,6 @@ public final class InfraBranchDatabaseTypeFixture implements
BranchDatabaseType
return TypedSPILoader.getService(DatabaseType.class,
"INFRA.TRUNK.FIXTURE");
}
- @Override
- public boolean isSchemaAvailable() {
- return true;
- }
-
@Override
public String getType() {
return "INFRA.BRANCH.FIXTURE";
diff --git
a/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/PipelineSQLSegmentBuilderTest.java
b/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/PipelineSQLSegmentBuilderTest.java
index d226c062fd5..e0e33c7466c 100644
---
a/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/PipelineSQLSegmentBuilderTest.java
+++
b/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/PipelineSQLSegmentBuilderTest.java
@@ -28,25 +28,25 @@ class PipelineSQLSegmentBuilderTest {
@Test
void assertGetEscapedIdentifier() {
- PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"INFRA.TRUNK.FIXTURE"));
+ PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"MySQL"));
assertThat(sqlSegmentBuilder.getEscapedIdentifier("SELECT"),
is("`SELECT`"));
}
@Test
void assertGetUnescapedIdentifier() {
- PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"INFRA.TRUNK.FIXTURE"));
- assertThat(sqlSegmentBuilder.getEscapedIdentifier("INSERT"),
is("INSERT"));
+ PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"MySQL"));
+ assertThat(sqlSegmentBuilder.getEscapedIdentifier("SELECT1"),
is("SELECT1"));
}
@Test
void assertGetQualifiedTableNameWithUnsupportedSchema() {
- PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"INFRA.TRUNK.FIXTURE"));
+ PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"MySQL"));
assertThat(sqlSegmentBuilder.getQualifiedTableName("foo_schema",
"foo_tbl"), is("foo_tbl"));
}
@Test
void assertGetQualifiedTableNameWithSupportedSchema() {
- PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"INFRA.BRANCH.FIXTURE"));
+ PipelineSQLSegmentBuilder sqlSegmentBuilder = new
PipelineSQLSegmentBuilder(TypedSPILoader.getService(DatabaseType.class,
"PostgreSQL"));
assertThat(sqlSegmentBuilder.getQualifiedTableName("foo_schema",
"foo_tbl"), is("foo_schema.foo_tbl"));
}
}