strongduanmu commented on code in PR #26330: URL: https://github.com/apache/shardingsphere/pull/26330#discussion_r1264297188
########## kernel/sql-federation/core/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/converter/segment/expression/impl/MySQLMatchAgainstFunction.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sqlfederation.compiler.converter.segment.expression.impl; + +import org.apache.calcite.sql.SqlFunctionCategory; +import org.apache.calcite.sql.SqlKind; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.SqlFunction; +import org.apache.calcite.sql.SqlCall; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlSyntax; +import org.apache.calcite.sql.SqlOperandCountRange; +import org.apache.calcite.sql.SqlLiteral; +import org.apache.calcite.sql.type.InferTypes; +import org.apache.calcite.sql.type.OperandTypes; +import org.apache.calcite.sql.type.ReturnTypes; +import org.apache.calcite.sql.type.SqlOperandCountRanges; +import org.apache.calcite.util.Util; + +import java.util.List; + +/** + * MySQL match against function. + */ +public final class MySQLMatchAgainstFunction extends SqlFunction { + + private static final SqlWriter.FrameType FRAME_TYPE = Review Comment: Please use static import to remove `SqlWriter.` ########## kernel/sql-federation/core/src/main/java/org/apache/shardingsphere/sqlfederation/compiler/converter/segment/expression/impl/MatchExpressionConverter.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sqlfederation.compiler.converter.segment.expression.impl; + +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlLiteral; +import org.apache.calcite.sql.SqlOperator; +import org.apache.calcite.sql.SqlBasicCall; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr.MatchExpression; +import org.apache.shardingsphere.sqlfederation.compiler.converter.segment.SQLSegmentConverter; +import org.apache.shardingsphere.sqlfederation.compiler.converter.segment.expression.ExpressionConverter; + +import java.util.LinkedList; +import java.util.List; +import java.util.Optional; + +/** + * Match expression converter. + */ +public final class MatchExpressionConverter implements SQLSegmentConverter<MatchExpression, SqlNode> { + + @Override + public Optional<SqlNode> convert(final MatchExpression segment) { + List<SqlNode> column = new LinkedList<>(); + column.add(new SqlIdentifier(segment.getColumnName().getIdentifier().getValue(), SqlParserPos.ZERO)); + SqlNode against = new ExpressionConverter().convert(segment.getExpr()).get(); + SqlNode searchModifier = SqlLiteral.createCharString("IN NATURAL LANGUAGE MODE", SqlParserPos.ZERO); Review Comment: Why not parse `IN NATURAL LANGUAGE MODE` to MatchExpression? ########## parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/expr/MatchExpression.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr; + +import lombok.Getter; +import lombok.RequiredArgsConstructor; +import lombok.Setter; +import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment; + +@RequiredArgsConstructor +@Getter +@Setter +public final class MatchExpression implements ExpressionSegment { + + private final int startIndex; + + private final int stopIndex; + + private final ColumnSegment columnName; + + private final ExpressionSegment expr; + + @Override + public String getText() { Review Comment: Why return null? ########## parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/segment/dml/expr/MatchExpression.java: ########## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.shardingsphere.sql.parser.sql.common.segment.dml.expr; + +import lombok.Getter; +import lombok.RequiredArgsConstructor; +import lombok.Setter; +import org.apache.shardingsphere.sql.parser.sql.common.segment.dml.column.ColumnSegment; + +@RequiredArgsConstructor +@Getter +@Setter +public final class MatchExpression implements ExpressionSegment { + + private final int startIndex; + + private final int stopIndex; + + private final ColumnSegment columnName; + + private final ExpressionSegment expr; Review Comment: Can you refer this class to implement MatchExpression? And then rename this class to MatchAgainstExpression. https://github.com/polardb/polardbx-sql/blob/main/polardbx-parser/src/main/java/com/alibaba/polardbx/druid/sql/ast/expr/SQLMatchAgainstExpr.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
