[shardingsphere] branch master updated: Add default impl of DialectPipelineSQLBuilder.buildEstimatedCountSQL() (#27210)

[panjuan]

This is an automated email from the ASF dual-hosted git repository.

panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new e247f347f67 Add default impl of 
DialectPipelineSQLBuilder.buildEstimatedCountSQL() (#27210)
e247f347f67 is described below

commit e247f347f67aa56bab4e44f0629c6daaef79d3c5
Author: Liang Zhang <zhangli...@apache.org>
AuthorDate: Sat Jul 15 12:15:08 2023 +0800

    Add default impl of DialectPipelineSQLBuilder.buildEstimatedCountSQL() 
(#27210)
---
 .../data/pipeline/spi/sqlbuilder/DialectPipelineSQLBuilder.java    | 4 +++-
 .../common/sqlbuilder/fixture/FixturePipelineSQLBuilder.java       | 5 -----
 .../test/it/data/pipeline/core/fixture/H2PipelineSQLBuilder.java   | 7 -------
 3 files changed, 3 insertions(+), 13 deletions(-)

diff --git 
a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/spi/sqlbuilder/DialectPipelineSQLBuilder.java
 
b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/spi/sqlbuilder/DialectPipelineSQLBuilder.java
index 855cc0c4148..568cd4903c3 100644
--- 
a/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/spi/sqlbuilder/DialectPipelineSQLBuilder.java
+++ 
b/kernel/data-pipeline/api/src/main/java/org/apache/shardingsphere/data/pipeline/spi/sqlbuilder/DialectPipelineSQLBuilder.java
@@ -64,7 +64,9 @@ public interface DialectPipelineSQLBuilder extends 
DatabaseTypedSPI {
      * @param tableName table name
      * @return estimated count SQL
      */
-    Optional<String> buildEstimatedCountSQL(String schemaName, String 
tableName);
+    default Optional<String> buildEstimatedCountSQL(String schemaName, String 
tableName) {
+        return Optional.empty();
+    }
     
     /**
      * Build CRC32 SQL.
diff --git 
a/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/fixture/FixturePipelineSQLBuilder.java
 
b/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/fixture/FixturePipelineSQLBuilder.java
index 2f44ec6f809..3eb73bc96c9 100644
--- 
a/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/fixture/FixturePipelineSQLBuilder.java
+++ 
b/kernel/data-pipeline/core/src/test/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/fixture/FixturePipelineSQLBuilder.java
@@ -28,11 +28,6 @@ public final class FixturePipelineSQLBuilder implements 
DialectPipelineSQLBuilde
         return String.format("SELECT * FROM %s LIMIT 1", tableName);
     }
     
-    @Override
-    public Optional<String> buildEstimatedCountSQL(final String schemaName, 
final String tableName) {
-        return Optional.empty();
-    }
-    
     @Override
     public Optional<String> buildCRC32SQL(final String schemaName, final 
String tableName, final String column) {
         return Optional.of(String.format("SELECT CRC32(%s) FROM %s", column, 
tableName));
diff --git 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/H2PipelineSQLBuilder.java
 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/H2PipelineSQLBuilder.java
index c92ca17c988..06f3862f63b 100644
--- 
a/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/H2PipelineSQLBuilder.java
+++ 
b/test/it/pipeline/src/test/java/org/apache/shardingsphere/test/it/data/pipeline/core/fixture/H2PipelineSQLBuilder.java
@@ -19,8 +19,6 @@ package 
org.apache.shardingsphere.test.it.data.pipeline.core.fixture;
 
 import 
org.apache.shardingsphere.data.pipeline.spi.sqlbuilder.DialectPipelineSQLBuilder;
 
-import java.util.Optional;
-
 public final class H2PipelineSQLBuilder implements DialectPipelineSQLBuilder {
     
     @Override
@@ -28,11 +26,6 @@ public final class H2PipelineSQLBuilder implements 
DialectPipelineSQLBuilder {
         return String.format("SELECT * FROM %s LIMIT 1", tableName);
     }
     
-    @Override
-    public Optional<String> buildEstimatedCountSQL(final String schemaName, 
final String tableName) {
-        return Optional.empty();
-    }
-    
     @Override
     public String getDatabaseType() {
         return "H2";