strongduanmu commented on code in PR #27219:
URL: https://github.com/apache/shardingsphere/pull/27219#discussion_r1264613524
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -63,7 +63,9 @@ nullValueLiterals
;
identifier
- : IDENTIFIER_ | unreservedWord
Review Comment:
Please keep these branches in one line.
You can refer code conduct -
https://shardingsphere.apache.org/community/en/involved/conduct/code/.
> If a rule’s branch is over than 5, every branch take a new line.
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4:
##########
@@ -1358,7 +1358,8 @@ alterDatabase
;
databaseClauses
- : DATABASE databaseName | PLUGGABLE DATABASE pdbName
+ : DATABASE databaseName?
Review Comment:
Same with previous one.
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -63,7 +63,9 @@ nullValueLiterals
;
identifier
- : IDENTIFIER_ | unreservedWord
Review Comment:
Please keep these branches in one line.
You can refer code conduct -
https://shardingsphere.apache.org/community/en/involved/conduct/code/.
> If a rule’s branch is over than 5, every branch take a new line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
