lancelly commented on code in PR #27572:
URL: https://github.com/apache/shardingsphere/pull/27572#discussion_r1279502532
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -800,7 +800,12 @@ castFunction
;
charFunction
- : CHAR LP_ expr (COMMA_ expr)* (USING ignoredIdentifier)? RP_
+ : (CHR | CHAR) LP_ expr (COMMA_ expr)* (USING charSet)? RP_
Review Comment:
Hi, it seems that `ignoredIdentifier` can not parse `NCHAR_CS`.
NCHAR_CS is the only charset that CHR function supports accoding to this:
![Uploading 截屏2023-07-31 23.39.09.png…]()
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/BaseRule.g4:
##########
@@ -800,7 +800,12 @@ castFunction
;
charFunction
- : CHAR LP_ expr (COMMA_ expr)* (USING ignoredIdentifier)? RP_
+ : (CHR | CHAR) LP_ expr (COMMA_ expr)* (USING charSet)? RP_
Review Comment:
Hi, it seems that `ignoredIdentifier` can not parse `NCHAR_CS`.
NCHAR_CS is the only charset that CHR function supports accoding to this:
![Uploading 截屏2023-07-31 23.39.09.png…]()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
