sandynz commented on code in PR #27542:
URL: https://github.com/apache/shardingsphere/pull/27542#discussion_r1281311897
##########
kernel/data-pipeline/scenario/cdc/protocol/src/main/proto/CDCResponseProtocol.proto:
##########
@@ -35,6 +35,10 @@ message CDCResponse {
ServerGreetingResult server_greeting_result = 3;
StreamDataResult stream_data_result = 4;
DataRecordResult data_record_result = 5;
+ LoginResult login_result = 6;
+ StartStreamingResult start_streaming_result = 7;
+ StopStreamingResult stop_streaming_result = 8;
+ DropStreamingResult drop_streaming_result = 9;
Review Comment:
Could we cache request type in client? Just like `request_id`. Then we could
get request type in client, and remove these definitions in `response`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
