terrymanu commented on a change in pull request #4477: Parse mysql variable
value for SET statement
URL:
https://github.com/apache/incubator-shardingsphere/pull/4477#discussion_r386195277
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/java/org/apache/shardingsphere/sql/parser/integrate/jaxb/domain/statement/dal/SetVariableStatementTestCase.java
##########
@@ -30,6 +30,9 @@
@Setter
public final class SetVariableStatementTestCase extends SQLParserTestCase {
- @XmlAttribute(name = "variable")
- private String variable;
+ @XmlAttribute(name = "variableName")
+ private String variableName;
+
+ @XmlAttribute(name = "variableValue")
Review comment:
Please reference other name of xml attribute, we prefer using `-` to
delimiter tow words.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
