RaigorJiang commented on code in PR #27956:
URL: https://github.com/apache/shardingsphere/pull/27956#discussion_r1285338015
##########
infra/datasource/core/src/test/java/org/apache/shardingsphere/infra/datasource/props/DataSourcePropertiesCreatorTest.java:
##########
@@ -81,4 +102,26 @@ private Map<String, Object> createProperties() {
result.put("maximumPoolSize", "-1");
return result;
}
+
+ private Map<String, Object> createStandardProperties() {
+ Map<String, Object> result = new LinkedHashMap<>(6, 1F);
+ // This is to test the case where the property type is mismatched.
Review Comment:
Hi @zhangfengcdt
Thanks for your PR!
According to [Code of
Conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/),
comments can only be used for Javadoc, todo and fixme, so please remove this
line of comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
