strongduanmu commented on code in PR #27994:
URL: https://github.com/apache/shardingsphere/pull/27994#discussion_r1292117346
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4:
##########
@@ -3257,6 +3257,462 @@ arryDMLSubClause
: LP_ typeName (COMMA_ varrayType)? RP_
;
+createMaterializedView
+ : CREATE MATERIALIZED VIEW materializedViewName
+ (OF typeName )?
Review Comment:
Can you inline these sytax rule?
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/DDLStatement.g4:
##########
@@ -3257,6 +3257,462 @@ arryDMLSubClause
: LP_ typeName (COMMA_ varrayType)? RP_
;
+createMaterializedView
+ : CREATE MATERIALIZED VIEW materializedViewName
+ (OF typeName )?
+ ( LP_ (scopedTableRefConstraint | mvColumnAlias) (COMMA_
(scopedTableRefConstraint | mvColumnAlias))* RP_ )?
+ ( ON PREBUILT TABLE ( (WITH | WITHOUT) REDUCED PRECISION)?
+ | physicalProperties? (CACHE | NOCACHE)? parallelClause? buildClause?
+ )
+ ( USING INDEX ( (physicalAttributesClause | TABLESPACE
tablespaceName)+ )*
+ | USING NO INDEX
+ )?
+ createMvRefresh?
+ (FOR UPDATE)?
+ ( (DISABLE | ENABLE) QUERY REWRITE )?
+ AS selectSubquery
+ ;
+
+rowLimitingClause
Review Comment:
Hi @zhangfengcdt , can you take a look at DMLStatement? I think
rowLimitingClause and selectSubquery already exist in DMLStatement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
