This is an automated email from the ASF dual-hosted git repository.

chengzhang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 647be3c6c3e Add todo for heldByConnection (#28163)
647be3c6c3e is described below

commit 647be3c6c3e3d4784387501ded497fc03e700038
Author: Zhengqiang Duan <[email protected]>
AuthorDate: Fri Aug 18 18:56:11 2023 +0800

    Add todo for heldByConnection (#28163)
    
    * Add todo for heldByConnection
    
    * Add todo for heldByConnection
---
 .../apache/shardingsphere/infra/executor/sql/process/ProcessEngine.java  | 1 +
 1 file changed, 1 insertion(+)

diff --git 
a/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessEngine.java
 
b/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessEngine.java
index 62d708cb0a7..d7b501fa7e9 100644
--- 
a/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessEngine.java
+++ 
b/infra/executor/src/main/java/org/apache/shardingsphere/infra/executor/sql/process/ProcessEngine.java
@@ -67,6 +67,7 @@ public final class ProcessEngine {
     public void executeSQL(final ExecutionGroupContext<? extends 
SQLExecutionUnit> executionGroupContext, final QueryContext queryContext) {
         if 
(isMySQLDDLOrDMLStatement(queryContext.getSqlStatementContext().getSqlStatement()))
 {
             String processId = 
executionGroupContext.getReportContext().getProcessId();
+            // TODO remove heldByConnection when jdbc connection support 
generate processId and call connect and disconnect
             boolean heldByConnection = null != 
ProcessRegistry.getInstance().get(processId) && 
ProcessRegistry.getInstance().get(processId).isHeldByConnection();
             ProcessIdContext.set(processId);
             ProcessRegistry.getInstance().add(new 
Process(queryContext.getSql(), executionGroupContext, heldByConnection));

Reply via email to