linghengqian commented on PR #24636: URL: https://github.com/apache/shardingsphere/pull/24636#issuecomment-1685500658
> > > yes need upgrade to support snakeyml 1.33 to 2.1 > > > > > > > > * @lizongbo Obviously we have two ways of thinking about dealing with downstream usage. One is to wait for the Release of ShardingSphere ElasticJob 3.0.4, and the other is to shade the SnakeYAML package, so that the downstream can use a higher version of the SnakeYAML API. > > * I assume you are interested in the first option, but I am not sure about the release plan of ShardingSphere ElasticJob 3.0.4. Would you like to start a discussion on the mailing list? > > This changed code is fully compatible with snakeyml 1.33, 2.0, 2.1. > > because The Representer class's old constructor Representer() was marked as Deprecated in 1.33 and then removed in version 2.0 > > "public Representer(DumperOptions options) " is exists in 1.33 ,2.0 and 2.1 . - @lizongbo It looks like the deprecated method on SnakeYAML 1.33 is used because new method of SnakeYAML 1.33 caused CI execution to fail. https://github.com/apache/shardingsphere/pull/21480 reintroduced methods that were deprecated on SnakeYAML 1.33. - @totalo I wonder if https://github.com/apache/shardingsphere/pull/21480 has any background information? https://github.com/apache/shardingsphere/pull/19293 doesn't mention SnakeYAML. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
