terrymanu commented on a change in pull request #4577: #4482 Correct the
`DataTypeName` for SQLServer
URL:
https://github.com/apache/incubator-shardingsphere/pull/4577#discussion_r386811520
##########
File path: sharding-sql-test/src/main/resources/sql/supported/ddl/alter.xml
##########
@@ -25,16 +25,17 @@
<sql-case id="alter_table_with_back_quota" value="ALTER TABLE `t_order`
FORCE" db-types="MySQL" />
<sql-case id="alter_table_add_column" value="ALTER TABLE t_order ADD
column4 VARCHAR(10)" />
<sql-case id="alter_table_add_columns" value="ALTER TABLE t_order ADD
column4 VARCHAR(10), ADD column5 VARCHAR(10), ADD column6 VARCHAR(10)"
db-types="MySQL,PostgreSQL" />
- <sql-case id="alter_table_add_columns_integer_type_mysql" value="ALTER
TABLE t_order ADD column4 TINYINT, ADD column5 MEDIUMINT" db-types="MySQL" />
+ <sql-case id="alter_table_add_columns_integer_type_mysql" value="ALTER
TABLE t_order ADD column4 INTEGER, ADD column5 TINYINT, ADD column6 MEDIUMINT"
db-types="MySQL" />
Review comment:
If the scope of this pr is for data type of SQLServer only, why do change
test case for MySQL?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
