bpzhang commented on code in PR #27904:
URL: https://github.com/apache/shardingsphere/pull/27904#discussion_r1326856985
##########
features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/route/engine/condition/engine/InsertClauseShardingConditionEngine.java:
##########
@@ -100,7 +100,7 @@ private void appendMissingShardingConditions(final
InsertStatementContext sqlSta
return;
}
for (String each : allColumnNames) {
- if (!columnNames.contains(each) &&
!shardingRule.isGenerateKeyColumn(each, tableName) &&
shardingRule.findShardingColumn(each, tableName).isPresent()) {
+ if (!columnNames.contains(each.toLowerCase()) &&
!shardingRule.isGenerateKeyColumn(each, tableName) &&
shardingRule.findShardingColumn(each, tableName).isPresent()) {
Review Comment:
https://user-images.githubusercontent.com/1734396/255540089-b905d899-c0e7-4053-abc3-f9f7df27054a.png
this method make all field to lowercase, but SS not process the field of
table, so there is a problem when table contain case-sensitive fields, even
though the field is same one ,such as 'accountNo'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
