This is an automated email from the ASF dual-hosted git repository.

zhaojinchao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new 1e1096ca5e0 Adjust parameter naming (#28899)
1e1096ca5e0 is described below

commit 1e1096ca5e035ca9db8ad59da02281e4007ece6a
Author: yx9o <[email protected]>
AuthorDate: Wed Nov 1 10:18:07 2023 +0800

    Adjust parameter naming (#28899)
---
 .../apache/shardingsphere/proxy/frontend/CDCServer.java    |  8 ++++----
 .../shardingsphere/proxy/frontend/ShardingSphereProxy.java | 14 +++++++-------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git 
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/CDCServer.java
 
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/CDCServer.java
index a435fa18d14..15023e3c4ec 100644
--- 
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/CDCServer.java
+++ 
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/CDCServer.java
@@ -78,11 +78,11 @@ public final class CDCServer extends Thread {
                 .childOption(ChannelOption.TCP_NODELAY, true)
                 .handler(new LoggingHandler(LogLevel.INFO))
                 .childHandler(new CDCServerHandlerInitializer());
-        List<ChannelFuture> futures = new ArrayList<>();
-        for (String address : addresses) {
-            futures.add(bootstrap.bind(address, port).sync());
+        List<ChannelFuture> result = new ArrayList<>();
+        for (String each : addresses) {
+            result.add(bootstrap.bind(each, port).sync());
         }
-        return futures;
+        return result;
     }
     
     private void createEventLoopGroup() {
diff --git 
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/ShardingSphereProxy.java
 
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/ShardingSphereProxy.java
index 5622e84cc22..5dd39ef6a3e 100644
--- 
a/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/ShardingSphereProxy.java
+++ 
b/proxy/frontend/core/src/main/java/org/apache/shardingsphere/proxy/frontend/ShardingSphereProxy.java
@@ -68,7 +68,7 @@ public final class ShardingSphereProxy {
     /**
      * Start ShardingSphere-Proxy.
      *
-     * @param port      port
+     * @param port port
      * @param addresses addresses
      */
     @SneakyThrows(InterruptedException.class)
@@ -104,11 +104,11 @@ public final class ShardingSphereProxy {
     private List<ChannelFuture> startInternal(final int port, final 
List<String> addresses) throws InterruptedException {
         ServerBootstrap bootstrap = new ServerBootstrap();
         initServerBootstrap(bootstrap);
-        List<ChannelFuture> futures = new ArrayList<>();
-        for (String address : addresses) {
-            futures.add(bootstrap.bind(address, port).sync());
+        List<ChannelFuture> result = new ArrayList<>();
+        for (String each : addresses) {
+            result.add(bootstrap.bind(each, port).sync());
         }
-        return futures;
+        return result;
     }
     
     private ChannelFuture startDomainSocket(final String socketPath) {
@@ -119,8 +119,8 @@ public final class ShardingSphereProxy {
     
     private void accept(final List<ChannelFuture> futures) throws 
InterruptedException {
         log.info("ShardingSphere-Proxy {} mode started successfully", 
ProxyContext.getInstance().getContextManager().getInstanceContext().getModeConfiguration().getType());
-        for (ChannelFuture future : futures) {
-            future.channel().closeFuture().sync();
+        for (ChannelFuture each : futures) {
+            each.channel().closeFuture().sync();
         }
     }
     

Reply via email to