sandynz commented on code in PR #28953:
URL: https://github.com/apache/shardingsphere/pull/28953#discussion_r1383076143
##########
kernel/data-pipeline/scenario/cdc/core/src/main/java/org/apache/shardingsphere/data/pipeline/cdc/core/importer/CDCImporter.java:
##########
@@ -86,7 +86,7 @@ protected void runBlocking() {
} else {
doWithoutSorting(channelProgressPairs);
}
- if (channelProgressPairs.isEmpty()) {
+ if (channelProgressPairs.isEmpty() && ackCache.estimatedSize() ==
0) {
break;
}
Review Comment:
1, Client could have related re-subscription
2, If client always no ack, then server side could close streaming after
some time out
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
